From owner-freebsd-ports-bugs@freebsd.org Fri May 22 06:56:18 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4BFAD3282AA for ; Fri, 22 May 2020 06:56:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49Sy2B1LWsz3d7V for ; Fri, 22 May 2020 06:56:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2C4983282A9; Fri, 22 May 2020 06:56:18 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2C1003282A8 for ; Fri, 22 May 2020 06:56:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49Sy2B0Qfmz3dRr for ; Fri, 22 May 2020 06:56:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 05D9F1ACF3 for ; Fri, 22 May 2020 06:56:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 04M6uH8A025282 for ; Fri, 22 May 2020 06:56:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 04M6uHe0025279 for ports-bugs@FreeBSD.org; Fri, 22 May 2020 06:56:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 246623] www/caddy: Update to 2.0.0 Date: Fri, 22 May 2020 06:56:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: buildisok X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: basil.hendroff@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 06:56:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246623 --- Comment #4 from Basil Hendroff --- (In reply to Daniel Tihanyi from comment #0) Hi Daniel, For my own understanding, how important is it that Caddy V2 create a PID fi= le, or require LOGIN and DAEMON? I haven't found these to be showstoppers in getting Caddy V2 working in the rc.d framework. This thread also seems to suggest that a PID file in not entirely necessary https://forums.freebsd.org/threads/rc-d-script-to-start-a-sh-script.63178/= =20 I've also independently worked on an rc script. Details can be found at https://github.com/basilhendroff/freenas-iocage-caddyv2. What's reassuring = is that we have got to similar points quite independently.=20 A couple of comments on your rc script. 1. I do like elements of what you've done especially around command_args and command flags. command_args=3D"${caddy_flags} -config ${caddy_config}" I wonder if the order should be switched though, or whether it matters? i.e= .=20 command_args=3D"--config ${caddy_config} ${caddy_flags}" Why? For instance, it may facilitate implementing a 'quiet mode'. As you wi= ll be aware, the Caddy start and reload commands generate quite a lot of outpu= t. In its simplest form, this can be prevented by setting caddy_flags=3D"> /de= v/null 2>&1" in /etc/rc.conf. 2. The script I came up with is very similar to yours, but deviates slightl= y in a couple of places. You might like to consider these deviations. 2.1 Kudos on the start, validate and reloads methods. However, it's not exa= ctly clear to me why you've implemented a separate stop method. The built-in met= hod appears to work well. 2.2 The location of the Caddyfile and Caddy executable, I've set up as configurable script parameters caddy_config_path and cadd_bin_path. For instance, I think in the V1 rc script, the default Caddyfile location was /usr/local/www/Caddyfile. This may be important for some users migrating fr= om V1 to V2. Thank you for offering to maintain the port. This was raised as recently as= a few hours ago by the Caddy dev in this Caddy forum post https://caddy.community/t/caddy-version-1-end-of-life-date/7835/26 --=20 You are receiving this mail because: You are the assignee for the bug.=