From owner-svn-src-all@freebsd.org Wed Oct 7 09:08:18 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30B6E9D08B8; Wed, 7 Oct 2015 09:08:18 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D4B133AF; Wed, 7 Oct 2015 09:08:17 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wiclk2 with SMTP id lk2so203321932wic.0; Wed, 07 Oct 2015 02:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=O1VQcqG4aGRatOeJEbyU25hVpl/1f4mN/8BlH6TggvM=; b=T9OTPN3goPYAT+mWlqm5Zq+L8DTkCk6yqBI2d+Ez0E7fKTe9r958jbhkmIAoNDHVL4 Oo7icGOhzPhh/ETLiDDEDG0bIR/SylQSSDmReBnlDQQolnh13Pt/racUPWWaISqol4Ux ni6rk68lrUjBxlWaKRFWj/TBETCI51T1SCSQSpRkZJtoyi30XiDhWMy+QhwQ8ibrMuss gug7XjHwbE2napFxMuJmdUzYGpFpDQX0+9EN62NquasoF9wNNMSymGD1TuhI/yHT9GUf PwyMtAu/7LbJEyXJVeDFlJzrT1XJ/BfXfX5zVC3Fvl3CN4b8n+ND213TnA3XTit/Z7VT iYcQ== X-Received: by 10.194.187.72 with SMTP id fq8mr41195532wjc.131.1444208896245; Wed, 07 Oct 2015 02:08:16 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id s2sm1653005wib.15.2015.10.07.02.08.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Oct 2015 02:08:15 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 7 Oct 2015 11:08:13 +0200 From: Baptiste Daroussin To: NGie Cooper Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r288981 - head/sbin/sysctl Message-ID: <20151007090812.GA91729@ivaldir.etoilebsd.net> References: <201510070856.t978u2mZ048215@repo.freebsd.org> <52FE118F-5C0E-4CC2-9078-27015D72315B@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: <52FE118F-5C0E-4CC2-9078-27015D72315B@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 09:08:18 -0000 --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 07, 2015 at 01:58:29AM -0700, NGie Cooper wrote: >=20 > > On Oct 7, 2015, at 01:56, Baptiste Daroussin wrote: > >=20 > > Author: bapt > > Date: Wed Oct 7 08:56:01 2015 > > New Revision: 288981 > > URL: https://svnweb.freebsd.org/changeset/base/288981 > >=20 > > Log: > > Trim spaces at the end of the buffer before trying to convert it to an= oid > >=20 > > This allows to write entries in sysctl.conf with spaces before the '= =3D' like > > kern.ipc.shmmax =3D 9663676416 > >=20 > > MFC after: 1 week > > Sponsored by: Gandi.net >=20 > Won=E2=80=99t this cause issues if the intent of the original value is to= have a space before the rest of the value, e.g. >=20 > sysctl my.oid=3D=E2=80=9C i really wanted a leading space=E2=80=9D Note that here I am only trimming spaces _before_ the =3D and I'm not touch= ing the parsing after the '=3D' for the exact reason you are raising. Best regards, Bapt --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYU4PwACgkQ8kTtMUmk6EyepwCfV9thV+voILJFAMtZ9uUA+6Sy qUwAn3eiyos1gVtzynuUjpxBpLMKpcOM =Jvmf -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--