Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 1999 15:07:49 -0600
From:      Nate Williams <nate@mt.sri.com>
To:        Alfred Perlstein <bright@rush.net>
Cc:        Nate Williams <nate@mt.sri.com>, "Brian F. Feldman" <green@FreeBSD.ORG>, hackers@FreeBSD.ORG, freebsd-ipfw@FreeBSD.ORG
Subject:   Re: securelevel and ipfw zero
Message-ID:  <199907282107.PAA03686@mt.sri.com>
In-Reply-To: <Pine.BSF.3.96.990728164752.20420J-100000@cygnus.rush.net>
References:  <199907282042.OAA03370@mt.sri.com> <Pine.BSF.3.96.990728164752.20420J-100000@cygnus.rush.net>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
> > > > In particular, the changes I pointed out are not 'cleanups', but style
> > > > changes.
> > > 
> > > When you make code readable, it's a cleanup.
> > 
> > The code is *NO* more readable by you re-ordering lines and changes
> > whitespace.
> 
> This is so very objective.

That's why it considered a 'stylistic' change, and not a functional
change.  And, that's why stylistic changes are not allowed to be mixed
with functional changes.

I quote from a recent article involving Brian early last week.
----------------------------------------------------------------------
From: "Jordan K. Hubbard" <jkh@zippy.cdrom.com>
Subject: Re: cvs commit: src/usr.sbin/inetd builtins.c 
Date: Fri, 23 Jul 1999 19:25:26 -0700

> > I realize that stack space is not really an issue. Do you think I care
> > about the possible savings of a few bytes? The issue is that variables
> > should be declared _in_the_proper_places_, so that's where they go in
> > my code. And yes, this is my code. I didn't appreciate Sheldon "restyling"
> > it, because that makes it harder for /me/ to maintain.
> 
> Having your own private coding style is arguably OK; using it
> in other's code is definitely not. Please stick to the coding style
> of the module you are editing.

Actually, I hadn't even considered that point but Mark's entirely
correct.  You don't get to pick your own style in the middle of code
that someone else has written, you stick to the SAME style even if
it's totally style(9) non-conformant and icky in the extreme.
....
----------------------------------------------------------------------

You don't get to change styles even if it's non-conformant.

> > Grow up and quit acting like a child who doesn't wanna follow the rules.
> 
> quit acting like and old fart that fears change. (*)

Fears change?  Not quite.  I was willing to write the necessary changes
myself if necessary (see previous email on this thread), but I wanted to
make sure it was both desirable (beyond one's person POV), as well as it
wouldn't negatively effect other users of the system.

> afaik, Brian is the mainter of ipfw, it should be noted so, so that
> if his changes break something it comes down on his head.  Trust
> me to say something if that occurs.  

Brian is *NOT* the maintainer of IPFW, and thinking that is silliness.
If you think that, then you're confused.  Being the last person to
commit something doesn't make you the committer, and even more so
committing one change to the code doesn't make you the committer.

I've committed two things to it, so I win by default in that case. :)



Nate




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message




Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?199907282107.PAA03686>