From owner-cvs-src@FreeBSD.ORG  Mon Jun 28 19:59:46 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 917BD16A4CE; Mon, 28 Jun 2004 19:59:46 +0000 (GMT)
Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3690C43D49; Mon, 28 Jun 2004 19:59:46 +0000 (GMT)
	(envelope-from gallatin@cs.duke.edu)
Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu
	[152.3.145.30])
	by duke.cs.duke.edu (8.12.10/8.12.10) with ESMTP id i5SJxjqM025821
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 28 Jun 2004 15:59:45 -0400 (EDT)
Received: (from gallatin@localhost)
	by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id i5SJxehV003059;
	Mon, 28 Jun 2004 15:59:40 -0400 (EDT)
	(envelope-from gallatin)
From: Andrew Gallatin <gallatin@cs.duke.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16608.30892.745161.730935@grasshopper.cs.duke.edu>
Date: Mon, 28 Jun 2004 15:59:40 -0400 (EDT)
To: Brian Fundakowski Feldman <green@FreeBSD.org>
In-Reply-To: <20040628193858.GG5635@green.homeunix.org>
References: <200406281915.i5SJFeaV060231@repoman.freebsd.org>
	<20040628152232.A2977@grasshopper.cs.duke.edu>
	<20040628193858.GG5635@green.homeunix.org>
X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_map.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2004 19:59:46 -0000


Brian Fundakowski Feldman writes:
 > On Mon, Jun 28, 2004 at 03:22:33PM -0400, Andrew Gallatin wrote:
 > > Andrew Gallatin [gallatin@FreeBSD.org] wrote:
 > > > gallatin    2004-06-28 19:15:40 UTC
 > > > 
 > > >   FreeBSD src repository
 > > > 
 > > >   Modified files:
 > > >     sys/vm               vm_map.c 
 > > >   Log:
 > > >   Fix alpha - the use of min() on longs was loosing the high bits and
 > > >   returning wrong answers, leading to strange values vm2->vm_{s,t,d}size.
 > > 
 > > Why are min() and max() inlines which operate on ints?  This seems
 > > like a real landmine for 64-bit platforms..
 > 
 > Also, why is GCC not generating the correct warnings?  The values passed
 > in were definitely a 64-bit type.  Thanks for finding and fixing this.

I wish I knew.   I'm afraid this may bite us at some other point?

 > The inlines seem to exist to work around the effect of using macros
 > unknowingly on statements with side effects.  These should really be
 > MIN(), and there seems to have been an extra tab that crept in.  Do
 > you think you could change those things?

Sure.  Already done.  Thanks for the blessing to use MIN().

Drew