From owner-svn-src-head@freebsd.org  Fri Jun  8 14:08:47 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E21C101B8C8;
 Fri,  8 Jun 2018 14:08:47 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-it0-x233.google.com (mail-it0-x233.google.com
 [IPv6:2607:f8b0:4001:c0b::233])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C8EDD83397;
 Fri,  8 Jun 2018 14:08:46 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by mail-it0-x233.google.com with SMTP id u4-v6so2513682itg.0;
 Fri, 08 Jun 2018 07:08:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc;
 bh=ZeISHb7q7Qn8BggT2sn35YmgOEMcj84jAHb4JEZ0UlE=;
 b=oueEXZiaXk47gvu3hrwuYQk9tTc9EVpa9D87P6a51c+jKzx+3wFZ04LiLBUTuLXb0F
 A7LzgwU8ofk7/ETXPRxGBXSuanGgZcCU6Wygk00mM6hz0fzQsNm+I1UyGLeLglxz8ID6
 6148VP/VW/Uv3NB354x6bLzYnUpHh5Wn64pb30RcHHfIPVxYpCXvi6p7ZFXu28d2JRvQ
 vt+A34yku/CxCSZ9NTIJsOIix/qm8A9Trxq9vpgbAZn8Q1vQRsmC4Fa8kgJ1jmg/cv0r
 CmJ5k+7vKhFZakG1NisCayuc+EEKNfggT7AezuxBeIh+Yzlhv720Swnzs5mKqf6EIp+u
 Ditw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc;
 bh=ZeISHb7q7Qn8BggT2sn35YmgOEMcj84jAHb4JEZ0UlE=;
 b=lBxkxroTDKOZhK8FlxH6Q+1Kz0N7DGiSqXG7QMvCwH5BXlut5IIE+dmmz84XpXDagE
 YUQ6kYk18Bid/8VB6GZC32xNR2QP94RksFi0Xt4CWb9ArPrg6hVXhjmurSLXcojx178Y
 L9hLaeJttouyKmW7k7IUEMWAEW54uc3XU9oY4nEUOUndS2dMVzEaPndei7LvRSgNiSir
 aqGU1j6HRoLfB7YAiu+KAxIjugtibgXOLACvFkDH2wArkQdV4I7GkvTGiXv+oVhzJ3l6
 pmCgrWUYgLbb3zrrNo9ooIjTmCokhgW4qm+mbb57ohpjiTCvS66h/cVedlIfDcyXiL8b
 VHvQ==
X-Gm-Message-State: APt69E1eC0bMR228h2m79ORyQhMaARR5xWLAL2wbz5HMHyF2YaGu/rst
 kynSb/MaVYglhoQrYwT9sd59nM3B1/dewoT5AFaZPg==
X-Google-Smtp-Source: ADUXVKKDyMBsW3aFUrrytEdb3t4vsB//StUNlxYTzxj3FpszK7DEpxTBjTgtRFzter0NC1qxO2ZnS1GUw1nQBzZH7Ao=
X-Received: by 2002:a24:1fce:: with SMTP id
 d197-v6mr1764364itd.52.1528466925968; 
 Fri, 08 Jun 2018 07:08:45 -0700 (PDT)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 2002:a6b:87c4:0:0:0:0:0 with HTTP;
 Fri, 8 Jun 2018 07:08:25 -0700 (PDT)
In-Reply-To: <201806072049.w57Kn1Mk057119@repo.freebsd.org>
References: <201806072049.w57Kn1Mk057119@repo.freebsd.org>
From: Ed Maste <emaste@freebsd.org>
Date: Fri, 8 Jun 2018 10:08:25 -0400
X-Google-Sender-Auth: ypGArUjKBuQrdJzpoq8m6UMrbqM
Message-ID: <CAPyFy2DxmjVw57vu9Cbn7X1qfgR58UtTzvMk2rzEHxfhBHm79g@mail.gmail.com>
Subject: Re: svn commit: r334814 - head/sbin/dump
To: Kirk McKusick <mckusick@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 14:08:47 -0000

On 7 June 2018 at 16:49, Kirk McKusick <mckusick@freebsd.org> wrote:
> Author: mckusick
> Date: Thu Jun  7 20:49:01 2018
> New Revision: 334814
> URL: https://svnweb.freebsd.org/changeset/base/334814
>
> Log:
>   Ensure proper initialization of superblock.
>
...
> --- head/sbin/dump/main.c       Thu Jun  7 19:57:55 2018        (r334813)
> +++ head/sbin/dump/main.c       Thu Jun  7 20:49:01 2018        (r334814)
> @@ -433,6 +433,7 @@ main(int argc, char *argv[])
>                 msgtail("to %s\n", tape);
>
>         sync();
> +       sblock = NULL;
>         if ((ret = sbget(diskfd, &sblock, -1)) != 0) {

sblock is initialized to NULL at the beginning of ffs_sbget, so I'm
not really sure what's happening here.