Date: Fri, 12 Feb 2016 12:08:55 -0700 From: Adam Weinberger <adamw@adamw.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: Mathieu Arnold <mat@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r408737 - head/ports-mgmt/portmaster Message-ID: <01DE2FBD-BE93-4100-BB6A-72898EAE6F46@adamw.org> In-Reply-To: <CAMuy=%2Bj7WuNR5%2B90fmMH7oBX-5BjeDEj0teLrrSC1ip8v9_5Aw@mail.gmail.com> References: <201602121546.u1CFk4fB037748@repo.freebsd.org> <CAMuy=%2Bj7WuNR5%2B90fmMH7oBX-5BjeDEj0teLrrSC1ip8v9_5Aw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 12 Feb, 2016, at 11:01, Jason Helfman <jgh@FreeBSD.org> wrote: >=20 > On Fri, Feb 12, 2016 at 7:46 AM, Mathieu Arnold <mat@freebsd.org> = wrote: >> Author: mat >> Date: Fri Feb 12 15:46:04 2016 >> New Revision: 408737 >> URL: https://svnweb.freebsd.org/changeset/ports/408737 >>=20 >> Log: >> Remove unneeded dependencies on bash and zsh. >>=20 >> With hat: portmgr >> Sponsored by: Absolight >>=20 >> Modified: >> head/ports-mgmt/portmaster/Makefile >>=20 >> Modified: head/ports-mgmt/portmaster/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:34:10 2016 = (r408736) >> +++ head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:46:04 2016 = (r408737) >> @@ -2,6 +2,7 @@ >>=20 >> PORTNAME=3D portmaster >> PORTVERSION=3D 3.17.9 >> +PORTREVISION=3D 1 >> CATEGORIES=3D ports-mgmt >> MASTER_SITES=3D LOCAL/bdrewery/${PORTNAME}/ \ >> http://mirror.shatow.net/freebsd/${PORTNAME}/ \ >> @@ -24,9 +25,6 @@ PLIST_FILES=3D sbin/portmaster \ >> BASH_PLIST_FILES=3D etc/bash_completion.d/portmaster.sh >> ZSH_PLIST_FILES=3D share/zsh/site-functions/_portmaster >>=20 >> -BASH_RUN_DEPENDS=3D bash>=3D0:${PORTSDIR}/shells/bash >> -ZSH_RUN_DEPENDS=3D zsh>=3D0:${PORTSDIR}/shells/zsh >> - >> verify: checksum >>=20 >=20 > Does this break run dependency if a user chooses option of bash/zsh, > as helper files will be installed, but > bash/zsh won't be installed? Yes, it does. But it's better without the dependencies. The actual program itself works perfectly without bash or zsh. But then = you install zsh one day and *poof* you get completions. Removing zsh = shouldn't deinstall portmaster, upgrading zsh shouldn't reinstall = portmaster, and errors in the zsh port shouldn't prevent portmaster = packages from being produced. The bigger problem is that the completions aren't enabled by default. = Ports should do what pkg does: install completions as part of the = default package. My car is capable of pairing with Android phones and iPhones, but that = doesn't mean it needs to include an Android phone and an iPhone when you = buy the car. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01DE2FBD-BE93-4100-BB6A-72898EAE6F46>