From owner-svn-ports-head@freebsd.org Fri May 13 20:19:19 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94174B3AF32; Fri, 13 May 2016 20:19:19 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 89AD41B33; Fri, 13 May 2016 20:19:19 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 8833D1A5F; Fri, 13 May 2016 20:19:19 +0000 (UTC) Date: Fri, 13 May 2016 20:19:19 +0000 From: Alexey Dokuchaev To: Baptiste Daroussin Cc: Ed Maste , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415078 - in head: . Mk Message-ID: <20160513201919.GA48945@FreeBSD.org> References: <201605121820.u4CIKROJ004026@repo.freebsd.org> <20160513160151.GA30219@FreeBSD.org> <20160513182837.GF49383@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160513182837.GF49383@ivaldir.etoilebsd.net> User-Agent: Mutt/1.6.0 (2016-04-01) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 20:19:19 -0000 On Fri, May 13, 2016 at 08:28:37PM +0200, Baptiste Daroussin wrote: > On Fri, May 13, 2016 at 04:01:51PM +0000, Alexey Dokuchaev wrote: > > On Thu, May 12, 2016 at 06:20:27PM +0000, Ed Maste wrote: > > > New Revision: 415078 > > > URL: https://svnweb.freebsd.org/changeset/ports/415078 > > > > > > Log: > > > Record TIMESTAMP in make makesum > > > > > > This is intended to support development and prototyping for ports > > > reproducible build efforts which require some concept of a "last > > > updated" time. It is being committed now so that timestamp entries > > > will be populated "for free" as port distfiles updates happen. > > > > Why does it have to be part of distinfo rather than obtained from keywords > > or "svn info distinfo | grep ..."? (The latter might seem like it could > > slow things down a bit, but 1) it's unclear if it would make a significant > > difference without actual tests, and 2) polluting distinfo looks worse, to > > me at least.) > > First the svn keyword date will be updated too often (each cosmetic change > in a makefile) resulting in making reproducible builds less efficient. > > Second the ports tree is available in plenty of forms where the keywords > are not expanded: git, hg etc. breaking as such the reproducible builds[.] (*sigh* I knew that I shouldn't have brought keywords into the argument.) Anyway, why this information can't be fetched from the metadata? Why does it have to be tied to distinfo? What about patch files, sed(1) calls in the Makefile, etc.? Is there a place we can read more about this whole reproducible builds thing? ./danfe