Date: Sat, 29 May 2004 11:23:42 -0700 From: Luigi Rizzo <rizzo@icir.org> To: Marius Strobl <marius@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/mii acphy.c amphy.c bmtphy.c brgphy.c dcphy.c exphy.c lxtphy.c mii.c mii_physubr.c nsgphy.c nsphy.c pnaphy.c pnphy.c qsphy.c rgephy.c rlphy.c tdkphy.c tlphy.c ukphy.c ukphy_subr.c xmphy.c Message-ID: <20040529112342.A55353@xorpc.icir.org> In-Reply-To: <200405291809.i4TI9Bds073061@repoman.freebsd.org>; from marius@FreeBSD.org on Sat, May 29, 2004 at 11:09:10AM -0700 References: <200405291809.i4TI9Bds073061@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
any chance that one day we try to collapse the common code into a set of default functions and a table with device types etc ? At a quick glance many routines seem to be cut&pasted, with minor reordering of blocks that i am not even sure if they are correct or just the result of partial fixes to some modules but not others. cheers luigi On Sat, May 29, 2004 at 11:09:10AM -0700, Marius Strobl wrote: > marius 2004/05/29 11:09:10 PDT > > FreeBSD src repository > > Modified files: > sys/dev/mii acphy.c amphy.c bmtphy.c brgphy.c dcphy.c > exphy.c lxtphy.c mii.c mii_physubr.c > nsgphy.c nsphy.c pnaphy.c pnphy.c qsphy.c > rgephy.c rlphy.c tdkphy.c tlphy.c ukphy.c > ukphy_subr.c xmphy.c > Log: > Remove double __FBSDID and move the remaining one into a common place after > the license(s) and before the driver comment (the latter only in drivers not > having __FBSDID at that location). > > Revision Changes Path > 1.15 +3 -6 src/sys/dev/mii/acphy.c > 1.15 +0 -3 src/sys/dev/mii/amphy.c > 1.7 +3 -3 src/sys/dev/mii/bmtphy.c > 1.30 +0 -3 src/sys/dev/mii/brgphy.c > 1.25 +0 -3 src/sys/dev/mii/dcphy.c > 1.18 +3 -6 src/sys/dev/mii/exphy.c > 1.13 +3 -6 src/sys/dev/mii/lxtphy.c > 1.19 +0 -3 src/sys/dev/mii/mii.c > 1.21 +0 -3 src/sys/dev/mii/mii_physubr.c > 1.17 +0 -3 src/sys/dev/mii/nsgphy.c > 1.21 +3 -6 src/sys/dev/mii/nsphy.c > 1.14 +0 -3 src/sys/dev/mii/pnaphy.c > 1.17 +0 -3 src/sys/dev/mii/pnphy.c > 1.13 +3 -6 src/sys/dev/mii/qsphy.c > 1.4 +3 -3 src/sys/dev/mii/rgephy.c > 1.19 +0 -3 src/sys/dev/mii/rlphy.c > 1.15 +0 -3 src/sys/dev/mii/tdkphy.c > 1.17 +3 -6 src/sys/dev/mii/tlphy.c > 1.16 +3 -6 src/sys/dev/mii/ukphy.c > 1.8 +0 -3 src/sys/dev/mii/ukphy_subr.c > 1.15 +0 -3 src/sys/dev/mii/xmphy.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040529112342.A55353>