Date: Fri, 18 Jul 2008 12:58:17 +0200 From: "Paul B. Mahol" <onemda@gmail.com> To: "Andrew Thompson" <thompsa@freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: kern/125181: [ndis] [patch] with wep enters kdb.enter.unknown, panics Message-ID: <3a142e750807180358i4e3baa3m9ebe7cad357fe2cf@mail.gmail.com> In-Reply-To: <200807171650.m6HGo4aK018239@freefall.freebsd.org> References: <200807171650.m6HGo4aK018239@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/17/08, Andrew Thompson <thompsa@freebsd.org> wrote: > The following reply was made to PR kern/125181; it has been noted by GNATS. > > From: Andrew Thompson <thompsa@FreeBSD.org> > To: Coleman Kane <cokane@FreeBSD.org> > Cc: bug-followup@FreeBSD.org, onemda@gmail.com > Subject: Re: kern/125181: [ndis] [patch] with wep enters kdb.enter.unknown, > panics > Date: Thu, 17 Jul 2008 09:43:42 -0700 > > On Thu, Jul 17, 2008 at 12:09:52PM -0400, Coleman Kane wrote: > > Andrew, > > > > I got directed to this PR by onemda@gmail.com (Paul D. Mahol), who's > > been helping me track down some edge cases in the if_ndis locking > > rewrite. I am not 100% familiar with the locking semantics in play here > > (IEEE80211 and VAPs), so I wanted to run it by you before I determine > > that it seems to be working well for me. > > I dont think ndis should be reaching into the net80211 lock. Now that > ndis uses a regular mutex its a good chance to add mtx_asserts in the > right places and get the locking up to speed. I will try to post a patch > soon unless someone beats be to it. Patch impact on performance is marginal if not completely irrelevant. The only way to improve code in that file is rewritting offending functions. And at end net80211 lock would be still there (called via some other function).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a142e750807180358i4e3baa3m9ebe7cad357fe2cf>