From owner-svn-ports-head@freebsd.org Thu Jun 15 00:55:16 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CCE7CBF794D; Thu, 15 Jun 2017 00:55:16 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5576C7F279; Thu, 15 Jun 2017 00:55:16 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 6ED8216173; Thu, 15 Jun 2017 00:55:15 +0000 (UTC) Date: Thu, 15 Jun 2017 00:55:15 +0000 From: Alexey Dokuchaev To: "Tobias C. Berner" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r443599 - head/Mk Message-ID: <20170615005515.GA26393@FreeBSD.org> References: <201706142018.v5EKIc8G062340@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201706142018.v5EKIc8G062340@repo.freebsd.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2017 00:55:16 -0000 On Wed, Jun 14, 2017 at 08:18:38PM +0000, Tobias C. Berner wrote: > New Revision: 443599 > URL: https://svnweb.freebsd.org/changeset/ports/443599 > > Log: > Add note, that WRKDIRPREFIX must not end in '/'. > > PR: 199297 This is stupid, fragile, error-prone appoach that does not even cover all cases (like shown in the PR) when no paths end in slash but the problem still occurs. Did you read the analysis of my original problem carefully enough? It was not about slashes, it was symlinks and realpath. You might not like proposed solution but then think of something better; computers are smart enough to handle slashes automagically rather than depend on that unrealiable human beings will follow the rules and notes. ./danfe