From owner-freebsd-python@FreeBSD.ORG  Sat Sep 17 19:25:30 2011
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
Delivered-To: python@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F16C2106564A;
	Sat, 17 Sep 2011 19:25:30 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com
	[209.85.210.182])
	by mx1.freebsd.org (Postfix) with ESMTP id B0A178FC08;
	Sat, 17 Sep 2011 19:25:30 +0000 (UTC)
Received: by iadk27 with SMTP id k27so5757269iad.13
	for <multiple recipients>; Sat, 17 Sep 2011 12:25:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=ulzCA1kdMDkRIlW2gn0QIWb8zZWiJselqSAbCUh7NP0=;
	b=HBfKstERm6wNSnLWUPUrZrgQkTDZggvwpT31O/+6p/YqQz31d1RTaOxHpgkViyhI2j
	OUcIdkTPkmRZRGdBBfMWrox4IJVf/FRV5yy/+NJwN3uWtx7OZdYgrkkJUw6J3w1sJU1F
	d70Uwh5HIfYykamC6TjsDNLgzqKgPR9FtbGq0=
Received: by 10.42.29.68 with SMTP id q4mr1310078icc.99.1316287530142; Sat, 17
	Sep 2011 12:25:30 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.231.35.194 with HTTP; Sat, 17 Sep 2011 12:25:00 -0700 (PDT)
In-Reply-To: <CAGFTUwOhU8jO6cVYzsKEGduoBiiFhCVP1cpp6G_0EEP7yxu3-w@mail.gmail.com>
References: <CAGFTUwOhU8jO6cVYzsKEGduoBiiFhCVP1cpp6G_0EEP7yxu3-w@mail.gmail.com>
From: Chris Rees <utisoft@gmail.com>
Date: Sat, 17 Sep 2011 20:25:00 +0100
Message-ID: <CADLo8386i5N_OzW5p0ZnMbh=51aJQZqkaDQ8a8kh3CCVeyWfcg@mail.gmail.com>
To: bf1783@gmail.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: python@freebsd.org, bug-followup@freebsd.org
Subject: Re: ports/115940: Missed one file in lang/python25 if NO_NIS defined
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, 
	<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
	<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Sep 2011 19:25:31 -0000

On 13 September 2011 09:05, b. f. <bf1783@googlemail.com> wrote:
>> This problem has been going on for a number of years, and as far as I
>> can see there isn't a proper and elegant solution.
>>
>> A fix is at [1], which should solve the problem, and I'm going to
>> tinderbox test and commit it if no-one complains.
>
> As Kozlov said earlier, that's a bit ugly. =A0I think it would be better
> to avoid attempting to build the module in the first place, by simply
> adding something like:
>
> .if !exists(/usr/bin/ypcat) # the world with NO_NIS
> =A0 =A0 =A0 =A0${REINPLACE_CMD} -e 's|rpcsvc/yp_prot.h|${NONEXISTENT}|' \
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${PATCH_WRKSRC}/setup.py
> .endif
>
> to the pre-patch target, or something like:
>
> .if !exists(/usr/bin/ypcat) # the world with NO_NIS
> =A0 =A0 =A0 =A0${REINPLACE_CMD} -e '\|disabled_module_list =3D|s|]|, "nis=
"&|' \
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0${PATCH_WRKSRC}/setup.py
> .endif

Good point, and thanks for the idea, even if it did take me ten
minutes to work out how the hell your REINPLACE line worked ;) I've
simplified it a little.

Is it better now? It works in tinderbox so far....

http://www.bayofrum.net/~crees/patches/python-nis_failed-fix-bffix.diff

Chris