From owner-freebsd-net@freebsd.org Thu Nov 12 15:19:25 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D805A2CB84 for ; Thu, 12 Nov 2015 15:19:25 +0000 (UTC) (envelope-from jeffrey.e.pieper@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx1.freebsd.org (Postfix) with ESMTP id DC9C71D65; Thu, 12 Nov 2015 15:19:24 +0000 (UTC) (envelope-from jeffrey.e.pieper@intel.com) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 12 Nov 2015 07:18:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,282,1444719600"; d="scan'208";a="848983413" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga002.jf.intel.com with ESMTP; 12 Nov 2015 07:18:08 -0800 Received: from orsmsx111.amr.corp.intel.com ([169.254.11.251]) by ORSMSX109.amr.corp.intel.com ([169.254.2.6]) with mapi id 14.03.0248.002; Thu, 12 Nov 2015 07:18:08 -0800 From: "Pieper, Jeffrey E" To: Steven Hartland , Ryan Stone CC: Jack F Vogel , "freebsd-net@freebsd.org" Subject: RE: Intel XL710 broken link down detection? Thread-Topic: Intel XL710 broken link down detection? Thread-Index: AQHRHS/VengOSJt7YEubdxSXTfgVc56Yf0ew Date: Thu, 12 Nov 2015 15:18:07 +0000 Message-ID: <2A35EA60C3C77D438915767F458D65688080C4A8@ORSMSX111.amr.corp.intel.com> References: <564357E0.1050002@freebsd.org> <56436A5F.4020102@multiplay.co.uk> <56446159.3080405@multiplay.co.uk> In-Reply-To: <56446159.3080405@multiplay.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiJhZGNmMDBjNS1iOWM5LTQ0ZDQtODRhOS1kNWU2NmY4MDk0NGQiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY1wvNVwvdko1S1Z5SE9HUGk1YnA5bklmRDVlUFg5SzVYNXJBOHBsWk13dmZRPSJ9 x-inteldataclassification: CTP_PUBLIC x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 15:19:25 -0000 We already have a fix in place that will be committed for review shortly.=20 Thanks, Jeff -----Original Message----- From: owner-freebsd-net@freebsd.org [mailto:owner-freebsd-net@freebsd.org] = On Behalf Of Steven Hartland Sent: Thursday, November 12, 2015 1:52 AM To: Ryan Stone Cc: Jack F Vogel ; freebsd-net@freebsd.org Subject: Re: Intel XL710 broken link down detection? Yes this works but a better way IMO would be to invert the bits we want: https://people.freebsd.org/~smh/ixl_int_init.patch If there are no objections then I'll commit this later today. Also just fixed the debug sysctls from causing panics when compiled with=20 INVARIANTS see: https://svnweb.freebsd.org/base?view=3Drevision&revision=3D290708 Regards Steve On 11/11/2015 16:31, Ryan Stone wrote: > On Wed, Nov 11, 2015 at 11:18 AM, Steven Hartland=20 > > wrote: > > Comparing this to the Linux driver which does detect the link down > I've discovered it actually polls the link status by default in > its watchdog. > > Disabling this with "ethtool --set-priv-flags eth1 LinkPolling > off" and the Linux driver also fails to detect link down. > > So this seems like a firmware or even hardware bug where it should > be reporting down events and the Linux driver has been updated to > workaround the problem? > > > No, apparently the Linux devs just didn't read the datasheet closely=20 > enough (and presumably the FreeBSD driver copied the mistake). There=20 > is a mask of interrupt causes that works backwards from how one would=20 > expect; you mask out events that you *don't* want rather than events=20 > that you do want. Both the Linux and FreeBSD drivers pass a mask of=20 > events that they want interrupts for (the only reason why it appears=20 > to work on link up is that the the AN Completed event fires when link=20 > is up, as far as I can tell). Try the following patch: > > https://people.freebsd.org/~rstone/patches/ixl_link_int.diff=20 > > _______________________________________________ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"