From owner-svn-src-head@freebsd.org Fri Mar 10 20:10:38 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7380AD068FD; Fri, 10 Mar 2017 20:10:38 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 031C31FBC; Fri, 10 Mar 2017 20:10:38 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wr0-x244.google.com with SMTP id g10so12859631wrg.0; Fri, 10 Mar 2017 12:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hvdGjB+NfkzlO75FJ1LlZNQv3HE2/C819QrE+uLZAOU=; b=DYk1zjERglRiktN7mALYdaFvgSE1eBQPztDBJ+VV8NKslaGBkHksOP6UWHTezP9Nzp gChV1UfnQhL4WW1inYM2WR2JYvmb9cDj7PnCTb4UrBcV3NPv02p/CY8M9FZVa0+WyvMR F7vG3mXo/txdTPs2CvORnPElOUhis+neNxGhEUfBQNB2nZoMhPfiX5uPtppwghsGrzyx beh+XPWDV8bAo22mB2qWXrS8XN7htgwGDzidzRS6ibef++CArCVjf8UCQ0uNQuNMyY1+ 9oHT5yYE/fiCcHHAi10mOqXZFxqK9Wlb3Dd85T05MVc47rWxMKEHiAZ+Ib1TmDFaAcgd sL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hvdGjB+NfkzlO75FJ1LlZNQv3HE2/C819QrE+uLZAOU=; b=AkDaMfU2ZcSxypoPLt/3QFA1ZUCPegHrO/eiIsY711y7y4YGsOBm2NKnpOU3YoHGle UDlfnkf5EOYuiqWAMo+ZuoHPcRXU4MeyOiwQHgvZzQ6r+uEVJQtKKVGPFwzH1EnO4vt1 eCQXIAePZu5zFKDl2RWmBfWV0h1F53EbdlVljqGdR1JXzU5YidiXgvBiDtZWCS9sq7YS JHbvEY0A7ZbHbNQmJqixSO/3IjIuadN9oBGu+v2ScGljc7ZmYQiHBtc4g+awayZ6kJmr EhmTGPvw5s5aqv+2Or1AzpCTOBD7uhEf8UMtm0HL8Yg6eK6EAU1PfniRQ7dX6JEC/xr/ 2IKw== X-Gm-Message-State: AMke39kiNHBQk4c8rH7v7o0jWTjuOFJfDey7j9naQO9x8FTmStNBGB+3c9pywbzaOy9dGc8vYv8Nn9mcvVv2ZA== X-Received: by 10.223.183.6 with SMTP id l6mr16835943wre.60.1489176636122; Fri, 10 Mar 2017 12:10:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.128.133 with HTTP; Fri, 10 Mar 2017 12:10:35 -0800 (PST) In-Reply-To: References: <201701100323.v0A3NMAI045868@repo.freebsd.org> <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> From: Adrian Chadd Date: Fri, 10 Mar 2017 12:10:35 -0800 Message-ID: Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf To: Warner Losh Cc: Navdeep Parhar , Ryan Stone , Sean Bruno , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 20:10:38 -0000 On 10 March 2017 at 12:09, Warner Losh wrote: > It's already in loader.hints. The bug is that ifconfig doesn't use a > library (which others can use) to find the module by name, but rather > assumes a particular filename -> module name mapping. Sounds like a GSoC project. :-) -adrian > Warner > > On Fri, Mar 10, 2017 at 1:07 PM, Adrian Chadd wr= ote: >> s/ifconfig/put-it-in-a-config-file-in-share-so-we-dont-have-to-patch-ifc= onfig-every-time-we-change-this-kthxbai/g >> >> >> -adrian >> >> >> On 10 March 2017 at 11:12, Navdeep Parhar wrote: >>> On Fri, Mar 10, 2017 at 10:41 AM, Ryan Stone wrote: >>>> There's also the issue that running "ifconfig igb0 blah" during startu= p will >>>> cause if_igb to be automatically loaded by ifconfig. >>>> >>>> I guess we could add a dummy if_igb.ko that just has a dependency on >>>> if_em.ko >>> >>> I do similar stuff in cxgbe (if_cxl.ko and if_cc.ko exist solely to >>> drag in if_cxgbe.ko as a dependency). In hindsight I wish I'd just >>> added a list of ifnet names -> kld map to ifconfig instead. It would >>> have been an ugly hack but much simpler. >>> >>> Regards, >>> Navdeep >>> >>>> >>>> On Fri, Mar 10, 2017 at 1:13 PM, Warner Losh wrote: >>>>> >>>>> On Fri, Mar 10, 2017 at 11:06 AM, Sean Bruno wro= te: >>>>> > >>>>> > >>>>> > On 02/15/17 03:06, Roger Pau Monn=C3=A9 wrote: >>>>> >> On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote: >>>>> >>> Author: sbruno >>>>> >>> Date: Tue Jan 10 03:23:22 2017 >>>>> >>> New Revision: 311849 >>>>> >>> URL: https://svnweb.freebsd.org/changeset/base/311849 >>>>> >>> >>>>> >>> Log: >>>>> >>> Migrate e1000 to the IFLIB framework: >>>>> >>> - em(4) igb(4) and lem(4) >>>>> >>> - deprecate the igb device from kernel configurations >>>>> >>> - create a symbolic link in /boot/kernel from if_em.ko to if_ig= b.ko >>>>> >> >>>>> >> This linking causes mfsBSD to choke when building an image from HE= AD. >>>>> >> It tries >>>>> >> to issue the following command: >>>>> >> >>>>> >> ${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot >>>>> >> >>>>> >> Which fails when finding the symbol link. I can send a patch to ch= ange >>>>> >> that to >>>>> >> -Rp, which would work fine, but wouldn't it be better to either >>>>> >> completely >>>>> >> remove if_igb.ko, or simply copy if_em.ko to if_igb.ko? >>>>> >> >>>>> >> I'm wondering if for example anyone strips down it's /boot/kernel/ >>>>> >> manually, by >>>>> >> removing unused modules, and what would happen if if_em.ko is remo= ved >>>>> >> but not >>>>> >> if_igb.ko. >>>>> >> >>>>> >> Roger. >>>>> >> >>>>> >> >>>>> > >>>>> > Well, this was my naive attempt to make upgrades for users to be >>>>> > non-eventful in the event they have "if_igb_load=3DYES" in their >>>>> > loader.conf instead of having it built into their kernel. >>>>> > >>>>> > If the -Rp works, I'll add that instead. >>>>> >>>>> The module name is encoded in the module itself. The boot loader look= s >>>>> it up to see which module to load. Maybe there's a way to fix it so >>>>> both load from one file? >>>>> >>>>> Warner >>>>> >>>> >>>