Date: Thu, 9 Aug 2018 07:30:28 -0500 From: Mark Felder <feld@feld.me> To: Adam Weinberger <adamw@adamw.org> Cc: Ryan Steinmetz <zi@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r476670 - in head/devel: . rubygem-solve Message-ID: <8632EEE8-AFFE-4BE6-8E58-CE83F7C9036E@feld.me> In-Reply-To: <CAP7rwcimLHj2eAYYfXAd609N=14RT8_SJFU2H1qZFk9Yk05sbg@mail.gmail.com> References: <201808081953.w78Jr68X078029@repo.freebsd.org> <CAP7rwciJj9U0TOEvnwSCc2hCWh_NF44pPjHfmQRu8MGCYq24AA@mail.gmail.com> <20180808202929.GA63276@exodus.zi0r.com> <20180808213446.gktmjqcyrfhjkrlk@atuin.in.mat.cc> <20180808215702.GB52659@exodus.zi0r.com> <CAP7rwcimLHj2eAYYfXAd609N=14RT8_SJFU2H1qZFk9Yk05sbg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_F51892A2-6FE2-403E-A122-E0A1B5938F00 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Aug 8, 2018, at 17:18, Adam Weinberger <adamw@adamw.org> wrote: >=20 > On Wed, Aug 8, 2018 at 3:57 PM Ryan Steinmetz <zi@freebsd.org> wrote: >>=20 >>=20 >> On (08/08/18 23:34), Mathieu Arnold wrote: >>>>> Ryan, >>>>>=20 >>>>> You've just added a number of ports with uninformative pkg-descrs, = and >>>>> unhelpful COMMENT strings. These aren't merely formalities. Users >>>>> should be able to read the pkg-descr and understand if it's the = right >>>>> package for them, and COMMENT is the first target for searches. >>>>> Please, go back over them and, at the very least, expand the = pkg-descr >>>>> files with more information. As a general rule, pkg-descr should = NEVER >>>>> be the same text as the COMMENT. >>>>=20 >>>> Adam, >>>>=20 >>>> These are the description strings from authors of the code. They = came from >>>> either rubygems.org and/or the gem source repository. For example, = in the >>>> case of rubygem-solve: >>>>=20 >>>> https://rubygems.org/gems/solve >>>>=20 >>>> https://github.com/berkshelf/solve >>>>=20 >>>> If you have any specific things you would like to see added to any = of the >>>> individual ports, please let me know. >>>=20 >>> pkg-descr must contain sentences, something that can be read. It = must at >>> least be two lines long, so that it is descriptive enough. The fact >>> that upstream is crappy does not mean you can put he same crap in = the >>> ports tree. It is your job as committer to make sure that ports = conform >>> to our policies and requirements. If upstream does not provide a = better >>> decription, create one, basd on your knowledge of the software. >>=20 >>=20 >> = https://svnweb.freebsd.org/ports/head/devel/p5-Data-Serializer-Sereal/pkg-= descr?revision=3D401986&view=3Dmarkup >>=20 >> = https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-afnic/pkg-des= cr?revision=3D380380&view=3Dmarkup >>=20 >> = https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-smallregistry= /pkg-descr?view=3Dmarkup >>=20 >> = https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-secdns/pkg-de= scr?revision=3D380380&view=3Dmarkup >=20 > Ryan, what exactly is it that you're arguing in favour of here? All I > requested was for you to please add some helpful information in the > descrs where possible. So far you've argued that uninformative descrs > are okay as long as you copied it from someone else, and that > uninformative descrs are okay because you're not the only one who does > it. >=20 > I'm trying to get people on board with fixing what's been an ongoing > problem in our ports. You've agreed with the problem, but not the > solution. If you have another solution to terse descrs that's > different from putting more information in descrs, I'm eager to hear > it. >=20 Adam, please stop. You cannot honestly expect committers to invent = descriptions for ports that have zero documentation. I have plenty of = ports myself that only exist in the tree because I had to chase = dependencies for the software I intended to port. Most of these are = libraries that have non-descript or "too-clever" names and of which I = have no idea what their function is. It is not my responsibility nor the = responsibility of any committer to fix this problem. --Apple-Mail=_F51892A2-6FE2-403E-A122-E0A1B5938F00 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEzBAEBCgAdFiEEVTp08j41/a0LK3IYqgNgwT+IDgUFAltsM+QACgkQqgNgwT+I DgWhsQgAnh65KCz1uwGuX76672nsNpyQ3Sw305GN7UFqr1J6WicLtoc/kkseD8yL 9uU97pZflpNSB0AtwX7v5qTtAkfGb5xK5F6uKc7XF1xlsOa4phd29rhb0M+dcSt4 oMbSQsB7uguY5LqJbBvh61lLIaDm5En0oOrbK6L5+b/ECJtfFO02LZ2z8Wp8vbgj U4J0+pC1YZcQvjWdgCLiyyaVChiuR9KytvAREtJqeIJanTZBBPDhRaavLV3L61s3 9c/WWMGqBQ9MHK9Sxdg7ve9SpQ2z2cxMVqdJSbsQLnq/qYwTIkElFPqhKwruYAsE rwOLqZmmJjpf/wMhwwB5ej8H2gWSnQ== =tg7l -----END PGP SIGNATURE----- --Apple-Mail=_F51892A2-6FE2-403E-A122-E0A1B5938F00--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8632EEE8-AFFE-4BE6-8E58-CE83F7C9036E>