Date: Mon, 04 Jul 2005 19:15:37 +0900 (JST) From: Noritoshi Demizu <demizu@dd.iij4u.or.jp> To: freebsd-net@freebsd.org Subject: Re: TCP MD5 Signature option handling in tcp_syncache.c Message-ID: <20050704.191537.90127740.Noritoshi@Demizu.ORG> In-Reply-To: <20050415.143521.57443821.Noritoshi@Demizu.ORG> References: <20050415.143521.57443821.Noritoshi@Demizu.ORG>
next in thread | previous in thread | raw e-mail | index | archive | help
> 1. When the TCP MD5 Signature option is used on a TCP connection, > both the TCP Timestamps option and the TCP Window Scale option > are turned off. > > I think the cause and the fix are as following: > At line 987 in tcp_syncache.c 1.70, sc->sc_flags is overwritten > by SCF_SIGNATURE. By this line, SCF_TIMESTAMP and SCF_WINSCALE > are turned off. I think the operator "=" should be "|=". > > 987: - sc->sc_flags = SCF_SIGNATURE; > 987: + sc->sc_flags |= SCF_SIGNATURE; I files this problem as kern/82963. Regards, Noritoshi Demizu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050704.191537.90127740.Noritoshi>