Date: Sat, 3 Feb 2007 06:01:58 -0800 From: Luigi Rizzo <rizzo@icir.org> To: Alexander Leidinger <Alexander@leidinger.net> Cc: cvs-ports@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/linux-kmod-compat Makefile distinfo pkg-descr pkg-plist Message-ID: <20070203060157.A8811@xorpc.icir.org> In-Reply-To: <20070203144930.6a63fbf4@Magellan.Leidinger.net>; from Alexander@leidinger.net on Sat, Feb 03, 2007 at 02:49:30PM %2B0100 References: <200702021808.l12I8KBY073193@repoman.freebsd.org> <1170440345.33849.0.camel@ikaros.oook.cz> <20070202103221.C97555@xorpc.icir.org> <1170441475.33849.7.camel@ikaros.oook.cz> <20070202113527.A98938@xorpc.icir.org> <1170446129.2386.4.camel@ikaros.oook.cz> <20070202121416.B99198@xorpc.icir.org> <1170447689.2386.8.camel@ikaros.oook.cz> <20070202124620.B99548@xorpc.icir.org> <20070203144930.6a63fbf4@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 03, 2007 at 02:49:30PM +0100, Alexander Leidinger wrote: > Quoting Luigi Rizzo <rizzo@icir.org> (Fri, 2 Feb 2007 12:46:20 -0800): ... > > maybe they are stable packages. This one is changing frequently now. > > Anyways, it's my code, it's my choice. You can delete this and > > another thousand ports if you don't like the idea of NO_PACKAGE > > ports. > > The main complaint is about the missing plist. NO_PACKAGE is a ports you are misreading things. In fact, i think a lot of this thread derived by misunderstanding of what was in the actual port. The plist was present from the beginning, and had full instruction to cleanup after itself also from the beginning. Surely i would have preferred to use some magic such as @this-is-my-subtree %%DATADIR%%/linux-kmod-compat and @deltree %%DATADIR%%/linux-kmod-compat to inform the ports infrastructure that my requirements are at the subtree level and not at the file level (something that i will discuss more in a reply to your other message). The main complaint was about the use of 'rm -rf' instead of the non-existent @deltree, which i admit is a shortcut, but i also tried to explain why i did that (besides there being other 99 instances of 'rm -rf' in pkg-plist in the ports tree, most of which do this for good reasons e.g. cleanup temp dirs or large header directories.) cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070203060157.A8811>