Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Jul 1999 23:10:44 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        "Brian F. Feldman" <green@FreeBSD.org>
Cc:        "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>, freebsd-current@FreeBSD.org
Subject:   Re: is dumpon/savecore broken? 
Message-ID:  <22434.932505044@critter.freebsd.dk>
In-Reply-To: Your message of "Tue, 20 Jul 1999 17:08:17 EDT." <Pine.BSF.4.10.9907201707210.71734-100000@janus.syracuse.net> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.10.9907201707210.71734-100000@janus.syracuse.net>, "Bria
n F. Feldman" writes:
>On Tue, 20 Jul 1999, Poul-Henning Kamp wrote:
>
>> In message <Pine.BSF.4.10.9907201658350.71734-100000@janus.syracuse.net>, "Bria
>> n F. Feldman" writes:
>> 
>> >> 	/ddname = find_dev/s/BLK/CHR/
>> >
>> >No, that's wrong. You cannot do buffered-type IO on a cdev. I committed
>> >a workaround, and now it works. There's no easy way around this, except
>> >possibly making kern.dumpdev a string (makes quite a bit of sense there...)
>> 
>> Indeed.  a dev_t should never be exported as such from the kernel
>> anymore, in particular not for bdevs.  dumps and swap are the two
>> offenders left.
>
>Should I commit a similar workaround for the swap code too? Quite
>simple to do...

Please so, but I would appreciate if you would do me the favour of
hiding the guts of this monstrosity in kern/kern_conf.c in a function
called dev2budev() ?

--
Poul-Henning Kamp             FreeBSD coreteam member
phk@FreeBSD.ORG               "Real hackers run -current on their laptop."
FreeBSD -- It will take a long time before progress goes too far!


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22434.932505044>