Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Jun 2005 14:32:51 -0700
From:      Brooks Davis <brooks@one-eyed-alien.net>
To:        Julian Elischer <julian@elischer.org>
Cc:        Brooks Davis <brooks@one-eyed-alien.net>, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrew Gallatin <gallatin@cs.duke.edu>, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/man/man9 ifnet.9 src/sys/compat/ndis kern_ndis.c subr_ndis.c src/sys/contrib/altq/altq altq_rio.c src/sys/contrib/dev/oltr if_oltr.c if_oltr_pci.c if_oltrvar.h src/sys/contrib/pf/net if_pflog.c if_pflog.h if_pfsync.c ...
Message-ID:  <20050610213251.GD11303@odin.ac.hmc.edu>
In-Reply-To: <42AA0619.9000904@elischer.org>
References:  <200506101649.j5AGnOPu077043@repoman.freebsd.org> <20050610170818.A32249@grasshopper.cs.duke.edu> <20050610211621.GA11303@odin.ac.hmc.edu> <42AA0619.9000904@elischer.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--n2Pv11Ogg/Ox8ay5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 10, 2005 at 02:28:57PM -0700, Julian Elischer wrote:
>=20
>=20
> Brooks Davis wrote:
>=20
> >On Fri, Jun 10, 2005 at 05:08:18PM -0400, Andrew Gallatin wrote:
> >=20
> >
> >>
> >>What is the appropriate way to detach an interface now?  I used to
> >>call just ether_ifdetach(ifp); Now I call both if_detach and if_free.
> >>Eg:
> >>
> >>   ether_ifdetach(ifp);
> >>   if_free(ifp);
> >>  =20
> >>
> >
> >This is correct.
>=20
> why does if_ether_detatch not call if_free()?

Symmetry, but importantly, because some drivers change their if_type and
this messing up the basic call to if_free.  It's possible that in the
future we'll want to move this into if_detach.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--n2Pv11Ogg/Ox8ay5
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFCqgcCXY6L6fI4GtQRAu5uAKCt8zQIr+Z4h4XRAg4LoUCko42V1wCeMne7
ANfr/Dgwod+Dxe171RfED9k=
=sJxF
-----END PGP SIGNATURE-----

--n2Pv11Ogg/Ox8ay5--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050610213251.GD11303>