Date: Mon, 13 Nov 1995 23:30:07 -0800 From: David Greenman <davidg@Root.COM> To: Bruce Evans <bde@zeta.org.au> Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c Message-ID: <199511140730.XAA00205@corbin.Root.COM> In-Reply-To: Your message of "Tue, 14 Nov 95 18:22:25 %2B1100." <199511140722.SAA00861@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>bde 95/11/13 21:16:38 >>> >>> Modified: sys/nfs nfs_syscalls.c >>> Log: >>> Included <sys/sysproto.h> to get central declarations for syscall args >>> structs and prototypes for syscalls. >>> >>> Ifdefed duplicated decentralized declarations of args structs. It's >>> convenient to have this visible but they are hard to maintain. Some >>> are already different from the central declarations. 4.4lite2 puts >>> them in comments in the function headers but I wanted to avoid the >>> large changes for that. > >> Now that the definitions are in sysproto.h, I'd like to see them removed >>from the .c files. > >I'm not sure if they should be removed as far as that. Do you think we >should remove the pseudo-declarations from all vnode op functions too? >Such declarations are useful iff they are correct. For examples of >possibly harmful incorrect ones, see almost any readdir(): The vnode op functions are auto-generated and not really part of the source tree. I see syscalls as being different since the delarations are now in a standard, centralized place. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511140730.XAA00205>