Date: Mon, 20 Nov 2017 10:22:12 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 217555] New port: editors/kakoune Vim-inspired, selection-oriented code editor Message-ID: <bug-217555-13-ydIgmJ7ck5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-217555-13@https.bugs.freebsd.org/bugzilla/> References: <bug-217555-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217555 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> --- Hi, I don't know if this is still relevant, but here is a quick review. I'm sure the port could use an update to a newer commit too now :) XPORTVERSION=3D 0.0.1 ... XGH_TAGNAME=3D 8703f30 Please don't invent version numbers like this. If the project has no tagged release yet use a version with a date like g20171120. XLICENSE_NAME=3D UNLICENSE XLICENSE_PERMS=3D dist-mirror dist-sell pkg-mirror pkg-sell auto-accept These can go away. We have it in bsd.licenses.db.mk now. X.if (${OSVERSION} < 1100000) XBUILD_DEPENDS+=3D ${LOCALBASE}/bin/clang++38:lang/clang38 X XCXX=3D clang++38 X.endif Why is this necessary? X.include <bsd.port.pre.mk> ... XUSES=3D gmake ncurses USES cannot be set after including bsd.port.pre.mk. It has no effect then. This is probably also why gmake was added to BUILD_DEPENDS manually. XDATADIR=3D ${PREFIX}/share/kak XDOCSDIR=3D ${PREFIX}/share/doc/kak Can the build be changed to install files into ${PREFIX}/share/kakoune instead? Xdo-build: X cd ${WRKSRC}/src && CXX=3D${CXX} ${GMAKE} && ${GMAKE} doc X cd ${WRKSRC}/doc && a2x --no-xmllint -f manpage kak.1.txt && ${GZIP_CMD} kak.1 This is wrong. To build something after the regular build a post-build target can be added and to build multiple targets ALL_TARGET=3D all doc To pass environment variables to gmake set MAKE_ENV. Xpost-install: X ${LN} -Fs rc ${STAGEDIR}${DATADIR}/autoload ${RLN} seems like a better choice here. Please confirm that it passes QA checks like poudriere testport and portlint too.=20 Thanks! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217555-13-ydIgmJ7ck5>