From owner-freebsd-audit Sat Nov 24 2:23: 8 2001 Delivered-To: freebsd-audit@freebsd.org Received: from relay1.ntu-kpi.kiev.ua (www.ntu-kpi.kiev.ua [212.111.192.161]) by hub.freebsd.org (Postfix) with ESMTP id 19E1737B419 for ; Sat, 24 Nov 2001 02:23:04 -0800 (PST) Received: from comsys.ntu-kpi.kiev.ua (eth0.comsys.ntu-kpi.kiev.ua [10.0.1.184]) by relay1.ntu-kpi.kiev.ua (Postfix) with ESMTP id 189792F1B0 for ; Sat, 24 Nov 2001 12:23:00 +0200 (EET) Received: (from root@localhost) by comsys.ntu-kpi.kiev.ua (8.11.6/8.11.6) id fAOAOpE14521 for freebsd-audit@FreeBSD.ORG.CHECKED; Sat, 24 Nov 2001 12:24:51 +0200 (EET) Received: from pm5149 (pm514-9.comsys.ntu-kpi.kiev.ua [10.18.54.109]) by comsys.ntu-kpi.kiev.ua (8.11.6/8.11.6) with SMTP id fAOAOl414513; Sat, 24 Nov 2001 12:24:47 +0200 (EET) Message-ID: <002101c174c9$02805d60$6d36120a@comsys.ntukpi.kiev.ua> From: "Andrey Simonenko" To: "Andrew R. Reiter" Cc: References: Subject: Re: xtend - unsafe signal handlers patch Date: Sat, 24 Nov 2001 12:18:42 +0300 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2014.211 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2014.211 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG ----- Original Message ----- From: Andrew R. Reiter Newsgroups: lucky.freebsd.audit Sent: Saturday, November 24, 2001 9:51 AM Subject: xtend - unsafe signal handlers patch > Due to "maintainers" lack of responding to my patch to fix some poor > signal handlers in xtend, I figured I should ship it over here for review > (or silence assuming it's ok). The patch is located at: > http://people.freebsd.org/~arr/patches/xtend-signal-warns.diff > I didn't completely check your patch, but it is better to change type of following variables from: +int hup_flag; /* received SIGHUP flag */ +int term_flag; /* received SIGTERM flag */ +int pipe_flag; /* received SIGPIPE flag */ to +volatile sig_atomic_t hup_flag; /* received SIGHUP flag */ +volatile sig_atomic_t term_flag; /* received SIGTERM flag */ +volatile sig_atomic_t pipe_flag; /* received SIGPIPE flag */ I think, because they are changed in signal handlers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message