From owner-cvs-src@FreeBSD.ORG Mon Jul 19 09:39:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8883616A4CE; Mon, 19 Jul 2004 09:39:42 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 330EE43D1D; Mon, 19 Jul 2004 09:39:42 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from pooker.samsco.org (scottl@localhost [127.0.0.1]) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i6J9jdhT053183; Mon, 19 Jul 2004 03:45:39 -0600 (MDT) (envelope-from scottl@freebsd.org) Received: from localhost (scottl@localhost)i6J9jdOG053180; Mon, 19 Jul 2004 03:45:39 -0600 (MDT) (envelope-from scottl@freebsd.org) X-Authentication-Warning: pooker.samsco.org: scottl owned process doing -bs Date: Mon, 19 Jul 2004 03:45:39 -0600 (MDT) From: Scott Long Sender: scottl@pooker.samsco.org To: Marcel Moolenaar In-Reply-To: <200407182028.i6IKS7Su002490@repoman.freebsd.org> Message-ID: <20040719034245.C32601@pooker.samsco.org> References: <200407182028.i6IKS7Su002490@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern imgact_elf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 09:39:42 -0000 On Sun, 18 Jul 2004, Marcel Moolenaar wrote: > marcel 2004-07-18 20:28:07 UTC > > FreeBSD src repository > > Modified files: > sys/kern imgact_elf.c > Log: > After maintaining previous behaviour in writing out the core notes, it's > time now to break with the past: do not write the PID in the first note. > Rationale: > 1. [impact of the breakage] Process IDs in core files serve no immediate > purpose to the debugger itself. They are only useful to relate a core > file to a process. This can provide context to the person looking at > the core file, provided one keeps track of this. Overall, not having > the PID in the core file is only in very rare occasions unfortunate. > 2. [reason of the breakage] Having one PRSTATUS note contain the PID, > while all others contain the LWPID of the corresponding kernel thread > creates an irregularity for the debugger that cannot easily be worked > around. This is caused by libthread_db correlating user thread IDs to > kernel thread (aka LWP) IDs and thus aware of the actual LWPIDs. > > Update comments accordingly. > > Revision Changes Path > 1.153 +5 -8 src/sys/kern/imgact_elf.c > I've seen concern (maybe in private email, can't check at the moment) recently that loosing the PID info is undesirable. Is there any way that it can be included again, maybe in something other than a PRSTATUS object? I'm not very familiar with how this stuff works, so forgive me if it's a naive question. Scott