From owner-svn-src-head@freebsd.org Mon Jun 3 14:17:14 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 242BB15B24E6; Mon, 3 Jun 2019 14:17:14 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B44DB827F4; Mon, 3 Jun 2019 14:17:13 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 45HcZG505Dz3c7W; Mon, 3 Jun 2019 14:17:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id BmCTDeXf072P; Mon, 3 Jun 2019 14:17:10 +0000 (UTC) Received: from garnet.daemonic.se (host-90-236-177-23.mobileonline.telia.com [90.236.177.23]) by mail.daemonic.se (Postfix) with ESMTPSA id 45HcZF5WB5z3c7V; Mon, 3 Jun 2019 14:17:09 +0000 (UTC) Subject: Re: svn commit: r348355 - head/sys/dev/iicbus To: Andriy Gapon , Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: jmd@freebsd.org References: <201905290908.x4T98L89066643@repo.freebsd.org> From: Niclas Zeising Message-ID: <72b2ce5e-4c4f-8857-b79b-0b2a412f23fe@freebsd.org> Date: Mon, 3 Jun 2019 16:17:09 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B44DB827F4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 14:17:14 -0000 On 2019-06-03 14:08, Andriy Gapon wrote: > On 03/06/2019 14:16, Niclas Zeising wrote: >> Hi! >> It seems like things broke after all, latest pkg build (on head-amd64)= reports >> this: >> >> >> /wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/sr= c/dev/drm2/i915/intel_iic.c:570:2: >> error: implicit declaration of function 'iicbus_set_nostop' is invalid= in C99 >> [-Werror,-Wimplicit-function-declaration] >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 iicbus_set_nostop(idev, tr= ue); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ >> /wrkdirs/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-12bd551/sr= c/dev/drm2/i915/intel_iic.c:570:2: >> error: this function declaration is not a prototype [-Werror,-Wstrict-= prototypes] >> 2 errors generated. >> >> Full log: >> >> http://beefy12.nyi.freebsd.org/data/head-amd64-default/p503023_s348376= /logs/drm-legacy-kmod-g20190523.log >=20 > Hi! Thank you for the report. > I am going to restore iicbus_set_nostop, but this time as a function th= at > modifies iicbus softc (instead of an ivar accessor for the bus). > I am including a patch that I would like to commit. >=20 > However, for the drm code to request the nostop mode correctly it needs= to be > fixed as well. > My proposed patch is here: https://github.com/FreeBSDDesktop/drm-legacy= /pull/9 >=20 Thank you, I will try it out. Will this break drm-legacy-kmod on 12, which doesn't have the iic bus=20 change you proposed? Regards --=20 Niclas Zeising