Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Jul 2004 22:52:59 -0500
From:      Alan Cox <alc@cs.rice.edu>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/vm vm_extern.h vm_kern.c
Message-ID:  <20040731035259.GL18577@cs.rice.edu>
In-Reply-To: <20040731001255.GA39839@darkness.comp.waw.pl>
References:  <200407252008.i6PK8xMm052000@repoman.freebsd.org> <20040731001255.GA39839@darkness.comp.waw.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 31, 2004 at 02:12:55AM +0200, Pawel Jakub Dawidek wrote:
> On Sun, Jul 25, 2004 at 08:08:59PM +0000, Alan Cox wrote:
> +> alc         2004-07-25 20:08:59 UTC
> +> 
> +>   FreeBSD src repository
> +> 
> +>   Modified files:
> +>     sys/vm               vm_extern.h vm_kern.c 
> +>   Log:
> +>   For years, kmem_alloc_pageable() has been misused.  Now that the last of
> +>   these misuses has been corrected, remove it before new ones appear, such as
> +>   arm/arm/pmap.c revision 1.8.
> 
> It probably needs __FreeBSD_version bump, because this function was used by
> vmware port, which is broken now.
> 

Done.

The uses of kmem_alloc_pageable() that I found in the vmware port
should be changed to kmem_alloc_nofault().  Such a change would
also be backward compatible, i.e., it would work on older versions.

Regards,
Alan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040731035259.GL18577>