From owner-freebsd-net@FreeBSD.ORG Tue Apr 29 17:25:16 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83DAA106567B for ; Tue, 29 Apr 2008 17:25:16 +0000 (UTC) (envelope-from agile.quad@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.242]) by mx1.freebsd.org (Postfix) with ESMTP id 3DE318FC19 for ; Tue, 29 Apr 2008 17:25:15 +0000 (UTC) (envelope-from agile.quad@gmail.com) Received: by an-out-0708.google.com with SMTP id b8so24126ana.13 for ; Tue, 29 Apr 2008 10:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=Dl/hDnKGbjZ/ENbmrIl1q1E0bktbvU0asdl1LJfIQt0=; b=IRaUfe0bfAEq7TYBJkCnnfYQHPjPDsEk1HEbldXFzdL8CXRTcuKNcagd19q3U38ys8MdhknNaLn8TfDyMMRRGVt+P35mOlBigLPAMPgxrcCWUEEg2RGoZbslu7YeqzblcA8Ci6hQaqOiM4RmHM8ZuMiPCP+woW2cnlUzObsdWOg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=mn9aaaywpBaiTNzIF9gEkqORmpFIpdK1WpUwvsQyZOx7kgf8GwCp5GRQcz32ytXYdCES11vUQ4I94zBYbbENHArRuJiaNL9Q5METDRjEthET/Ug3bXo/rMVKuaAiOOBkocupjKmDWD9KQbj3yZKc62NSboVpYY2IAMAvKxtNM6s= Received: by 10.100.241.17 with SMTP id o17mr1727420anh.4.1209489914835; Tue, 29 Apr 2008 10:25:14 -0700 (PDT) Received: by 10.100.211.16 with HTTP; Tue, 29 Apr 2008 10:25:13 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2008 20:25:13 +0300 From: Oleg To: pyunyh@gmail.com In-Reply-To: <20080417003713.GA28522@cdnetworks.co.kr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_19208_11845697.1209489914812" References: <1733112647.20080417004353@gmail.com> <20080417003713.GA28522@cdnetworks.co.kr> Cc: freebsd-net@freebsd.org Subject: Re: [bfe] [panic] Serious error: bfe failed to map RX buffer X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Apr 2008 17:25:16 -0000 ------=_Part_19208_11845697.1209489914812 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, sorry for long delay, was too busy. So, I recheck return code of bus_dmamap_load(9) and its exactly ENOMEM. Here are fresh patch with your suggestions (diff with HEAD) Best Regards, Oleg Dolgov. 2008/4/17, Pyun YongHyeon : > On Thu, Apr 17, 2008 at 12:43:53AM +0300, quad wrote: > > Hi, > > > > FreeBSD amd64 7.0-RELEASE, ULE, SMP. > > > > On heavy loads bfe network driver after few messages > > > > Serious error: bfe failed to map RX buffer > > Serious error: bfe failed to map RX buffer > > Serious error: bfe failed to map RX buffer > > ... > > > > make kernel panic. > > > > Here patch. > > > > > It would be even better if you can show me the return code of > bus_dmamap_load(9). If the error code is not ENOMEM it requires > more bus_dma(9) clean up(bfe(4) needs lots of bus_dma(9) fixing > and I had no time so far.) > Since the caller of bfe_list_newbuf() expects 0 or ENOBUFS it would > be even better to return ENOBUFS for failure case instead of > returning error code of bus_dmamap_load(9). > > -- > Regards, > > Pyun YongHyeon > ------=_Part_19208_11845697.1209489914812 Content-Type: application/octet-stream; name=if_bfe.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_ffmqch8w Content-Disposition: attachment; filename=if_bfe.diff LS0tIC9ob21lL2FnaWxlL1Byb2plY3RzL2Fub25jdnMvc3JjL3N5cy9kZXYvYmZlL2lmX2JmZS5j CTIwMDgtMDMtMTggMDQ6MTE6NDAuMDAwMDAwMDAwICswMjAwCisrKyBpZl9iZmUuYwkyMDA4LTA0 LTI5IDE5OjU1OjI3LjAwMDAwMDAwMCArMDMwMApAQCAtNjQ3LDExICs2NDcsMTIgQEAKIAlzdHJ1 Y3QgYmZlX2RhdGEgKnI7CiAJdV9pbnQzMl90IGN0cmw7CiAJaW50IGVycm9yOworCWludCBhbGxv Y2F0ZWQ7CiAKIAlpZiAoKGMgPCAwKSB8fCAoYyA+PSBCRkVfUlhfTElTVF9DTlQpKQogCQlyZXR1 cm4gKEVJTlZBTCk7CiAKLQlpZihtID09IE5VTEwpIHsKKwlpZigoYWxsb2NhdGVkID0gKG0gPT0g TlVMTCkpKSB7CiAJCW0gPSBtX2dldGNsKE1fRE9OVFdBSVQsIE1UX0RBVEEsIE1fUEtUSERSKTsK IAkJaWYobSA9PSBOVUxMKQogCQkJcmV0dXJuIChFTk9CVUZTKTsKQEAgLTY3MCw4ICs2NzEsMTMg QEAKIAlyID0gJnNjLT5iZmVfcnhfcmluZ1tjXTsKIAllcnJvciA9IGJ1c19kbWFtYXBfbG9hZChz Yy0+YmZlX3RhZywgci0+YmZlX21hcCwgbXRvZChtLCB2b2lkICopLAogCQkJTUNMQllURVMsIGJm ZV9kbWFfbWFwX2Rlc2MsIGQsIEJVU19ETUFfTk9XQUlUKTsKLQlpZiAoZXJyb3IpCi0JCXByaW50 ZigiU2VyaW91cyBlcnJvcjogYmZlIGZhaWxlZCB0byBtYXAgUlggYnVmZmVyXG4iKTsKKwlpZiAo ZXJyb3IpIHsKKwkJaWYgKGFsbG9jYXRlZCkKKwkJCW1fZnJlZShtKTsKKwkJaWYgKGVycm9yICE9 IEVOT01FTSkKKwkJCXByaW50ZigiU2VyaW91cyBlcnJvcjogYmZlIGZhaWxlZCB0byBtYXAgUlgg YnVmZmVyLCBlcnJvciAlZFxuIiwgZXJyb3IpOworCQlyZXR1cm4gKEVOT0JVRlMpOworCX0KIAli dXNfZG1hbWFwX3N5bmMoc2MtPmJmZV90YWcsIHItPmJmZV9tYXAsIEJVU19ETUFTWU5DX1BSRVdS SVRFKTsKIAogCWN0cmwgPSBFVEhFUl9NQVhfTEVOICsgMzI7Cg== ------=_Part_19208_11845697.1209489914812--