Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Apr 2019 17:29:26 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r346569 - head/usr.bin/ar
Message-ID:  <201904221729.x3MHTQHB037274@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Mon Apr 22 17:29:26 2019
New Revision: 346569
URL: https://svnweb.freebsd.org/changeset/base/346569

Log:
  ar: use array notation to access s_so
  
  This is somewhat more readable than pointer arithmetic.  Also remove an
  unnecessary cast while here.
  
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/usr.bin/ar/write.c

Modified: head/usr.bin/ar/write.c
==============================================================================
--- head/usr.bin/ar/write.c	Mon Apr 22 17:25:00 2019	(r346568)
+++ head/usr.bin/ar/write.c	Mon Apr 22 17:29:26 2019	(r346569)
@@ -673,11 +673,11 @@ write_objs(struct bsdar *bsdar)
 
 		for (i = 0; (size_t)i < bsdar->s_cnt; i++) {
 			if (w_sz == sizeof(uint32_t))
-				*(bsdar->s_so + i) =
-				    htobe32((uint32_t)(*(bsdar->s_so + i)) + pm_sz);
+				bsdar->s_so[i] =
+				    htobe32(bsdar->s_so[i] + pm_sz);
 			else
-				*(bsdar->s_so + i) =
-				    htobe64(*(bsdar->s_so + i) + pm_sz);
+				bsdar->s_so[i] =
+				    htobe64(bsdar->s_so[i] + pm_sz);
 		}
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904221729.x3MHTQHB037274>