From owner-svn-ports-all@freebsd.org Thu May 24 12:56:02 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76FCAEEFFBB; Thu, 24 May 2018 12:56:02 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay107.isp.belgacom.be (mailrelay107.isp.belgacom.be [195.238.20.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A26DA6A370; Thu, 24 May 2018 12:56:01 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3A3ud20hACIX/GS3Yxd8YUUyQJP3N1i/DPJgcQr6Af?= =?us-ascii?q?oPdwSP37p86wAkXT6L1XgUPTWs2DsrQY07GQ6/iocFdDyK7JiGoFfp1IWk1Nou?= =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZr?= =?us-ascii?q?KeTpAI7SiNm82/yv95HJbAhEmDSwbaluIBmqsA7cqtQYjYx+J6gr1xDHuGFIe+?= =?us-ascii?q?NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S6dYDCk9PGAu+MLrrxjD?= =?us-ascii?q?QhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VDK/5KlpVRDokj?= =?us-ascii?q?8KOTA5/m/Jl8J+j6BUoByuqBNjzIDZe52VOfhicq/BYd8WWXRNU8BMXCJBGIO8?= =?us-ascii?q?aI4PAvIfM+ZZrYn9o0YFoAW5BQmrH+Pg1DpIiWXw3a0hzu8sFh3G3A0iH9IKq3?= =?us-ascii?q?narM/1O7kMXu2o0afGwy/Pb/RM2Tfy8YXFdA0qr/+LXbJ1a8XRyE8vGhvLjlWK?= =?us-ascii?q?t4PqISia1v8QvGSB6OpgT+2vh3YpqgB+uDSvw8QshpHGhoIO1lDE7zt2z5wwJd?= =?us-ascii?q?KmUk53e9ukEJhWuiqHNIV2WtsvTmJ1tCog1LELtoO3cDIUxJg72RLTceGLfoiG?= =?us-ascii?q?7x/lSe2fOy13hGh/d7K6nxuy9E+gxfDiWcSsy1ZKqzZFksHLtnAQyxzf8siHRe?= =?us-ascii?q?V5/kemwTuP1Brc6uVFIUAxi6XbMZkhzqQslpoSs0TDGjX6l1nxjK+RbUUr5O2o?= =?us-ascii?q?5P7hYrX9vJOcMJV0ig7mPqQvnMywH/g4PxANUmSG4+iwyrLu8VDjTLlUkvE6jL?= =?us-ascii?q?PVvI3aKMkVvqK5BhVa0ocn6xaxFTem19EYkGEbLFJEehKHi5PkO1/UIP/mE/iw?= =?us-ascii?q?mE+snypxy/DBJL3hDY3BLmLfn7f5YbZ990lcxRIozdBB4ZJYE6kBIPXpWk/tr9?= =?us-ascii?q?zUFx85PBKuzOn6E9h92JkeVnyRDaCCK6PdrEWE5uU1I+mDfIUVoiryK+A55/7y?= =?us-ascii?q?in80gUQdfbev3ZcOcHC4Ge5mI1mCYXb1mNgBFWMKsxEwTOzwllKNTyVcZ22vUK?= =?us-ascii?q?4m4TE7Eo2mB5/ZRo+xmLyBwDu7HppOa2BeDVCMC2vod56dV/gQbyKSJ8phkj0Y?= =?us-ascii?q?Vbi9VYAhzwquuRT0y7p9MOXb5DYXtYn+29Rv4O3Tjx4y/yRuD8uBy2GNU310nm?= =?us-ascii?q?QQSj8zxq9/vVdwylmZ0admnfNXDsdT6O5TXgc9L57cwL8yN9enfwvdftaEVR6P?= =?us-ascii?q?WNOhBT15Gtc43/cgeUtwMe6OyBfZ0Hz5LaUSkum3BZ4wuonb2GP8Is970D6SyK?= =?us-ascii?q?gji3EIWMZCH1aKwKll+F6AVMbyj0yFmvPyJuwn1ynX+TLbwA=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2B4CQBBtQZb/5nK8VFdHAEBAQQBAQoBA?= =?us-ascii?q?YNEVA59FROMWowEAQGBeDEBXZUxLoRJAoIKIjgUAQIBAQEBAQECAWscDEIMAYF?= =?us-ascii?q?mIoJSAQU6HCMQCw4GBAklDyoeBhODJIIDC604iEaBdwWKSYEPgw2EYRKFVAKYX?= =?us-ascii?q?wmFaohlaowmiWaIcyGBUk0wCIJ+ixCFQD0wiguDJAEB?= X-IPAS-Result: =?us-ascii?q?A2B4CQBBtQZb/5nK8VFdHAEBAQQBAQoBAYNEVA59FROMWow?= =?us-ascii?q?EAQGBeDEBXZUxLoRJAoIKIjgUAQIBAQEBAQECAWscDEIMAYFmIoJSAQU6HCMQC?= =?us-ascii?q?w4GBAklDyoeBhODJIIDC604iEaBdwWKSYEPgw2EYRKFVAKYXwmFaohlaowmiWa?= =?us-ascii?q?IcyGBUk0wCIJ+ixCFQD0wiguDJAEB?= Received: from 153.202-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.202.153]) by relay.skynet.be with ESMTP; 24 May 2018 14:54:52 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id w4OCso9J053904; Thu, 24 May 2018 14:54:51 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Thu, 24 May 2018 14:54:50 +0200 From: Tijl Coosemans To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470615 - head Message-ID: <20180524145450.3345318f@kalimero.tijl.coosemans.org> In-Reply-To: <20180524124550.wxsfet7qts3zevq7@ogg.in.absolight.net> References: <201805221358.w4MDwYtl021212@repo.freebsd.org> <20180522160246.239217d9@kalimero.tijl.coosemans.org> <20180524124550.wxsfet7qts3zevq7@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 12:56:02 -0000 On Thu, 24 May 2018 14:45:50 +0200 Mathieu Arnold wrote: > On Tue, May 22, 2018 at 04:02:46PM +0200, Tijl Coosemans wrote: >> On Tue, 22 May 2018 13:58:34 +0000 (UTC) Mathieu Arnold wrote: >>> Author: mat >>> Date: Tue May 22 13:58:33 2018 >>> New Revision: 470615 >>> URL: https://svnweb.freebsd.org/changeset/ports/470615 >>> >>> Log: >>> Don't tell people to use @${FLAVOR} in that case, it's bad practice. >>> >>> Sponsored by: Absolight >>> >>> Modified: >>> head/CHANGES >>> >>> Modified: head/CHANGES >>> ============================================================================== >>> --- head/CHANGES Tue May 22 13:58:03 2018 (r470614) >>> +++ head/CHANGES Tue May 22 13:58:33 2018 (r470615) >>> @@ -152,8 +152,7 @@ AUTHOR: mat@FreeBSD.org >>> >>> In all the ports with Python dependencies, the *_DEPENDS entries MUST end >>> with the flavor so that the framework knows which to build/use. This is done >>> - by appending '@${PY_FLAVOR}' after the origin (or @${FLAVOR} if in a Python >>> - module with Python flavors, as the content will be the same). For example: >>> + by appending '@${PY_FLAVOR}' after the origin. For example: >>> >>> RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR} >> >> There are still some dependencies under Mk/ without @${PY_FLAVOR}. > > I cannot find any, can you be less vague? (or better, just fix them.) > Some lines that look suspicious: bsd.gstreamer.mk:python_DEPENDS= multimedia/py-gstreamer bsd.wx.mk:_WX_PORT_python_2.8= x11-toolkits/py-wxPython28 bsd.wx.mk:_WX_PORT_python_3.0= x11-toolkits/py-wxPython30 Uses/gnome.mk:pygobject_BUILD_DEPENDS= pygobject-codegen-2.0:devel/py-gobject Uses/gnome.mk:pygobject_RUN_DEPENDS= pygobject-codegen-2.0:devel/py-gobject Uses/gnome.mk:pygtk2_BUILD_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/pygtk-2.0.pc:x11-toolkits/py-gtk2 Uses/gnome.mk:pygtk2_RUN_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/pygtk-2.0.pc:x11-toolkits/py-gtk2 Uses/gnome.mk:pygnome2_BUILD_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/gnome-python-2.0.pc:x11-toolkits/py-gnome2 Uses/gnome.mk:pygnome2_RUN_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/gnome-python-2.0.pc:x11-toolkits/py-gnome2 Uses/gnome.mk:pygtksourceview_BUILD_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/pygtksourceview-2.0.pc:x11-toolkits/py-gtksourceview Uses/gnome.mk:pygtksourceview_RUN_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/pygtksourceview-2.0.pc:x11-toolkits/py-gtksourceview Uses/kde.mk:pykde4_PORT= devel/py-pykde4-kde4 Uses/kde.mk:pykdeuic4_PORT= devel/py-pykdeuic4-kde4