Date: Mon, 24 Oct 2005 22:20:18 -0700 From: "David O'Brien" <obrien@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Roman Kurakin <rik@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/cp if_cp.c Message-ID: <20051025052018.GE55418@dragon.NUXI.org> In-Reply-To: <200510241034.27073.jhb@freebsd.org> References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> <200510241034.27073.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 24, 2005 at 10:34:25AM -0400, John Baldwin wrote: > On Monday 24 October 2005 03:24 am, David O'Brien wrote: > > On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote: > > > rik 2005-09-27 16:57:45 UTC > > > FreeBSD src repository > > > Modified files: > > > sys/dev/cp if_cp.c > > > Log: > > > Restore if_cp.c 1.27 ... > > You should not have backed out my commit without discussing it with me > > and understanding the reason for the change. > > Do it again and I *will* be taking it Core. > > Looks like he added some function prototypes and moved the cdevsw up. Does i > compile now with gcc 4.0? It seems that his changes were a lot simpler and > didn't destroy nearly as much CVS history as your changes. It would really > be preferable to use simpler solutions rather than destroying version history > with really big diffs. Doesn't matter -- it was a clear back out of my recent commit. src/MAINTAINERS doesn't list any of these drivers, so what was his authority in unilaterally backing out my commit? It is also port portable to define static functions early in a file, before they are used. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051025052018.GE55418>