From owner-cvs-src@FreeBSD.ORG Tue Oct 25 05:20:21 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 597FF16A41F; Tue, 25 Oct 2005 05:20:21 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id C422F43D5A; Tue, 25 Oct 2005 05:20:18 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9P5KIxh067137; Mon, 24 Oct 2005 22:20:18 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9P5KIcm067136; Mon, 24 Oct 2005 22:20:18 -0700 (PDT) (envelope-from obrien) Date: Mon, 24 Oct 2005 22:20:18 -0700 From: "David O'Brien" To: John Baldwin Message-ID: <20051025052018.GE55418@dragon.NUXI.org> References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> <200510241034.27073.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510241034.27073.jhb@freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: Roman Kurakin , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/cp if_cp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2005 05:20:21 -0000 On Mon, Oct 24, 2005 at 10:34:25AM -0400, John Baldwin wrote: > On Monday 24 October 2005 03:24 am, David O'Brien wrote: > > On Tue, Sep 27, 2005 at 04:57:45PM +0000, Roman Kurakin wrote: > > > rik 2005-09-27 16:57:45 UTC > > > FreeBSD src repository > > > Modified files: > > > sys/dev/cp if_cp.c > > > Log: > > > Restore if_cp.c 1.27 ... > > You should not have backed out my commit without discussing it with me > > and understanding the reason for the change. > > Do it again and I *will* be taking it Core. > > Looks like he added some function prototypes and moved the cdevsw up. Does i > compile now with gcc 4.0? It seems that his changes were a lot simpler and > didn't destroy nearly as much CVS history as your changes. It would really > be preferable to use simpler solutions rather than destroying version history > with really big diffs. Doesn't matter -- it was a clear back out of my recent commit. src/MAINTAINERS doesn't list any of these drivers, so what was his authority in unilaterally backing out my commit? It is also port portable to define static functions early in a file, before they are used. -- -- David (obrien@FreeBSD.org)