Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 07 Jun 2015 17:41:54 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r284105 - head/bin/cp
Message-ID:  <5574C8B2.4020700@FreeBSD.org>
In-Reply-To: <20150607140621.GI2499@kib.kiev.ua>
References:  <201506070349.t573ngeh064017@svn.freebsd.org> <20150607140621.GI2499@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--jG0cP0iLUjUhQ1rbAHsBbIqikQXwO15oG
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 6/7/2015 9:06 AM, Konstantin Belousov wrote:
> On Sun, Jun 07, 2015 at 03:49:42AM +0000, Bryan Drewery wrote:
>> Author: bdrewery
>> Date: Sun Jun  7 03:49:41 2015
>> New Revision: 284105
>> URL: https://svnweb.freebsd.org/changeset/base/284105
>>
>> Log:
>>   Cleanup some indentation issues.
>>
>> Modified:
>>   head/bin/cp/utils.c
>>
>> Modified: head/bin/cp/utils.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/bin/cp/utils.c	Sat Jun  6 22:03:24 2015	(r284104)
>> +++ head/bin/cp/utils.c	Sun Jun  7 03:49:41 2015	(r284105)
>> @@ -122,18 +122,17 @@ copy_file(const FTSENT *entp, int dne)
>>  		    /* remove existing destination file name,=20
>>  		     * create a new file  */
>>  		    (void)unlink(to.p_path);
>> -				if (!lflag)
>> +		    if (!lflag) {
> It seems that the next two lines are indented in a funny way as well.

I fixed the "look" around code I was updating to make my update more clea=
r.

The whitespace in the lines I updated in this commit is still wrong in
many ways. There's several style/whitespace issues in the bin/cp files
and I wasn't sure what scope of reindentation would be acceptable to
others. If there's no objection I will cleanup all of the bin/cp files.


Regards,
Bryan Drewery




--jG0cP0iLUjUhQ1rbAHsBbIqikQXwO15oG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJVdMiyAAoJEDXXcbtuRpfPy3EIAMJ+D1uXcLODIdJ/Egsg7L0C
MI6uaxlJOeKni6nB7dq+8XXFN3EEwZFTljqgXyr4gBeSBM3Fd4jH4isfzahsoEls
KWH6RgR1wYF59zLmNji4jb+7OlwrYGK66DXhKgcSltWfe5oG2Yz4NFnY6pep/DKS
CQG9ZteYvMwDotLu4wD4P141EyeRvxpkgXmRIPMTXUCuZ5A5NvxrlhTeWmAGyDqG
jltEl4oHeK4jOCtcdnvYirjGiWVXMRbyANg9QK8ZzdWPn3oA3VbykJiS5hQDuTAV
TLYO6FLSD/+mr75mGYYUJMEkLVsHJyO6DO9Mr3REz2t+MuRKwNkXAJa9y0arUzc=
=7QIT
-----END PGP SIGNATURE-----

--jG0cP0iLUjUhQ1rbAHsBbIqikQXwO15oG--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5574C8B2.4020700>