From owner-freebsd-stable@FreeBSD.ORG Thu May 24 22:59:46 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6A6BF106566B; Thu, 24 May 2012 22:59:46 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by mx1.freebsd.org (Postfix) with ESMTP id C43878FC14; Thu, 24 May 2012 22:59:45 +0000 (UTC) Received: by wibhj8 with SMTP id hj8so5180770wib.13 for ; Thu, 24 May 2012 15:59:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=a1xk0hbpGywL/Xu+vadGTo7Sg842kR/L9u/bWNTyD7c=; b=YrXu/VIEsUfWj+vKuAmxndRAvyyDG3QWeW8GSWCHVTu7jgzLKWzRVLHF6GM6Q++Hlp 6XEFEehH5Ce12PAEEBdO0zCwQXyfuv4DzyKoaJDLndT9DGPh3IXU5SgHEeauru0HHuFx O0By31i8VMA37J8u6aHNXOYC7vG+4a43yC3UQRsgB494Ip/kpWCTjUGdDIAQ30E/noFb RYSmqgARdn4hLKPToRxiqQ8molFFXoRgyICd+WZZOj/gRQ0vzrjAg7a6/1Y+hv7qAMRW GIj6geE0Nj0tAe+FGm6I9UdEr4sEV5mK7djPtlGLxcuch+MUGlTtmxLOwIBvaSJs+vAK LNqA== Received: by 10.216.30.213 with SMTP id k63mr620638wea.59.1337900383605; Thu, 24 May 2012 15:59:43 -0700 (PDT) Received: from dft-labs.eu (dft-labs.eu. [80.87.128.179]) by mx.google.com with ESMTPS id d10sm13172360wiy.3.2012.05.24.15.59.41 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 May 2012 15:59:42 -0700 (PDT) Date: Fri, 25 May 2012 00:59:31 +0200 From: Mateusz Guzik To: Jamie Gritton Message-ID: <20120524225931.GD17579@dft-labs.eu> References: <1337887134.1908.20.camel@mike-PC> <20120524212219.GA17579@dft-labs.eu> <1337897210.1908.24.camel@mike-PC> <20120524221353.GB17579@dft-labs.eu> <1337898015.1908.27.camel@mike-PC> <20120524223004.GC17579@dft-labs.eu> <4FBEBA5C.7050804@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4FBEBA5C.7050804@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Mike Jakubik , "freebsd-stable@freebsd.org" Subject: Re: Jail startup/shutdown broken on latest 9-STABLE X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2012 22:59:46 -0000 On Thu, May 24, 2012 at 04:46:52PM -0600, Jamie Gritton wrote: > I'll get the patch to jail(8) in - thanks for catching that. But I > wonder about the patch to /etc/rc.d/jail. It looks correct, but I'm > going to see if it's /etc/rc.d/jail that needs changing, or if my recent > changes to jail(8) have changed the order in which things are written. > Yeah, was not sure whether I should change the order or the script. :) Would not it be better to just create empty persistent jail as first step? Since in this case only one line will be generated (jid), rc.d script will be able to just take the output - this seems much less fragile than the current method. Then of course it would proceed with jexec running /etc/rc and in the end drop persist flag. It looks like rc.d script still uses old syntax so this actually may be less trivial than it sounds. That being said, if this is idea sounds okay, I can try to come up with a patch this weekend. -- Mateusz Guzik