Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Sep 2014 06:09:46 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 179116] New port: graphics/xcftools Command-line tools for extracting from Gimp's XCF format
Message-ID:  <bug-179116-13-tO5ojlvCAZ@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-179116-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-179116-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D179116

John Marino <marino@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |Patch Ready

--- Comment #8 from John Marino <marino@FreeBSD.org> ---
Everything looks reasonable!


(In reply to Kalten from comment #5)
> * manual pages are not built (complicated problems=E2=80=94the Linux-vers=
ion
>   would not build them either)=E2=80=94maybe I will look into the problem=
 at
>   some time: it is not that urgent as each executable has a parameter
>   =E2=80=9C-h=E2=80=9D to reveal its usage information.

When you revise the port, you might consider pregenerating the manpage and
storing it and installing it from the "files" directory.


> * NLS is not a configurable option as the code uses it regardless of
>   switches=E2=80=94it simply needs nls.

okay.


> * There are regression tests: but they seem to be faulty (mentioned so
>   to the user and off by default)

okay.


> * LICENSE should be PD (PublicDomain) but there is no such thing until
>   now=E2=80=94to end the chaos there I have filed Bug 193573 and shall co=
rrect
>   it in graphics/xcftools when they will have answered to my report.


LICENSE is optional anyway.  However, if you want to see an example of PD
license implemented, you can follow the example in textproc/words port.



> > WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
> That is funny: If I alter =C2=BB#LICENSE=3D	PD=C2=AB in the Makefile to
> =C2=BBLICENSE=3D	GPLv3=C2=AB the warning regarding LIB_DEPENDS vanishes.
> So it seems to be no real fault in the Makefile.

It's because PD isn't a defined license most likely.




I'm moving this to the patch-ready pool.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-179116-13-tO5ojlvCAZ>