Date: Thu, 15 Jun 2017 08:16:58 +0200 From: "Tobias C. Berner" <tcberner@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Adam Weinberger <adamw@adamw.org>, "Tobias C. Berner" <tcberner@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r443599 - head/Mk Message-ID: <CAOshKteTJ2wY4%2BJq81tVV=NSWLAi%2Bbj%2B%2B2-14FaWfn5%2BUihmqA@mail.gmail.com> In-Reply-To: <20170615033928.GA66016@FreeBSD.org> References: <201706142018.v5EKIc8G062340@repo.freebsd.org> <20170615005515.GA26393@FreeBSD.org> <2E7EBFF9-6184-4CCA-BCAF-A3991EAF3A94@adamw.org> <20170615015635.GA78699@FreeBSD.org> <42DEC213-DF22-4BDF-9EA2-876629BA763C@adamw.org> <20170615033928.GA66016@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi there You're right, this only "addressed" the trailing slash issue and not the one with the symlink, which I forgot about. I think this should be fixed in qt5-qmake itself and not in the ports framework. I'll reopen it. mfg Tobias On 15 June 2017 at 05:39, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Wed, Jun 14, 2017 at 08:54:33PM -0600, Adam Weinberger wrote: >> > On 14 Jun, 2017, at 19:56, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >> > ... >> > [I] was somewhat disappointed that my PR was closed as WONTFIX (works >> > as intended) with no response to analysis of the problem, no discussion >> > of the proposed solution, etc. >> > >> > All the effort was flushed down the toilet. >> > >> > Needless to say, the problem is still there until someone else trips on >> > it and opens a similar PR. >> >> Consider opening a new PR (199297 turned into a different issue) and >> attaching a patch. > > I might do so, but I'd like to hear from Tobias first regarding the way > he had handled this one. Right now I'm a bit hesitant to spend time on > crafting a patch and filing another PR just to find out it is closed as > WONTFIX later again. > >> And there probably is merit to finding out what other stuff breaks >> when WRKDIRPREFIX != realpath WRKDIRPREFIX. > > Yeah, I mention this; there seems to be low interest though. > > ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOshKteTJ2wY4%2BJq81tVV=NSWLAi%2Bbj%2B%2B2-14FaWfn5%2BUihmqA>