From owner-freebsd-net@FreeBSD.ORG Tue Jan 18 17:51:33 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22C2F106578E; Tue, 18 Jan 2011 17:51:33 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 958B18FC1E; Tue, 18 Jan 2011 17:51:32 +0000 (UTC) Received: by vws9 with SMTP id 9so2505884vws.13 for ; Tue, 18 Jan 2011 09:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:date:to:cc:subject:message-id:reply-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=3yWFLdaJSo6CNJiSM425uEpVtcVJJGcvLOjGPZeQEBo=; b=EkZlogYm6jbM+oQmGBoOGbLrbu+lLqOBeHtJd7qIa12GHb9MUc+8VUdOMR3jbkjq4i Qw8WUjOtLT0ccHZfPHgmHNmicgZt5VbZSArKwrl3JrQXf8pHLuCm77IsK+TzGG9SoG3p jZ6kwIivBZW/3L3d0COaGKu8htQCP8D2ZVWrY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=RrjkU+wChxKiOv1SCi5kpRaf8svoRIu96DU4sFGJtxRPPEY0qzKZBSiCUpRsQWCYiT 3bJZaFjMTnUQ4o+M9g2I+TZq+g+sqC9DGwfeKE3p6lTjNUwh55K2RXipl+TbmbgmZFLW 9xLTw7v/v+Sl5mFRC0WrWm0UW23FJExydqvm4= Received: by 10.220.199.134 with SMTP id es6mr1427338vcb.250.1295373091777; Tue, 18 Jan 2011 09:51:31 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id e18sm3363177vbm.5.2011.01.18.09.51.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 18 Jan 2011 09:51:29 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 18 Jan 2011 09:50:36 -0800 From: Pyun YongHyeon Date: Tue, 18 Jan 2011 09:50:36 -0800 To: Paul Schenkeveld Message-ID: <20110118175036.GB5624@michelle.cdnetworks.com> References: <20110116124122.GA63358@psconsult.nl> <20110117195615.GA18423@psconsult.nl> <20110117212947.GA1210@michelle.cdnetworks.com> <20110117222624.GB1210@michelle.cdnetworks.com> <20110118023748.GA3170@psconsult.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110118023748.GA3170@psconsult.nl> User-Agent: Mutt/1.4.2.3i Cc: freebsd-net@freebsd.org, freebsd-stable@freebsd.org, re@freebsd.org Subject: Re: sis(4) broken on 8.2 [Re: Carp seems completely broken on 8.2-RC2 and 8.2-PRERELEASE] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2011 17:51:33 -0000 On Tue, Jan 18, 2011 at 03:37:48AM +0100, Paul Schenkeveld wrote: > Hello, > > On Mon, Jan 17, 2011 at 02:26:24PM -0800, Pyun YongHyeon wrote: > > > Since you didn't post dmesg output I'm not sure what kind of > > > controller you have but I guess it would be NS8381[56]. I > > > overhauled sis(4) to make it work on all architectures so one of > > > change, probably r212119, could be cause of the issue. Due to lack > > > of SiS controllers I didn't touch multicast handling part so some > > > part of code still relies on old wrong behavior of driver. > > > Would you try attached patch and let me know whether it makes any > > > difference? > > > > > > > Hmm, unfortunately it seems the patch above may not work since NS > > data sheet says that filter function should be disabled before > > touching other bits in the register. > > Try this one instead. > > As far as I can tell, both patches work for me. Your second patch is > on my production firewalls now so if anthing comes up over the > coming days I'll keep you informed. > > I've tested carp, both failover to backup and fallback (preemption) > with IPv4 and with IPv6, all seems to work now. > Thanks for testing. Committed to HEAD(r217548). > Thannks again for your patches, hope you can get them into 8.2. > I'm afraid it's too late. :-( > Regards, > > Paul Schenkeveld