Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Jul 2016 05:26:33 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 195929] usr.bin/sed -- constify, remove line-length limits
Message-ID:  <bug-195929-8-jXEfyLRP2M@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-195929-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-195929-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D195929

Mikhail Teterin <mi@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172273|0                           |1
        is obsolete|                            |

--- Comment #20 from Mikhail Teterin <mi@FreeBSD.org> ---
Created attachment 172402
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172402&action=
=3Dedit
Add come more const

(In reply to Pedro F. Giffuni from comment #19)
> Please review this update.

Seems fine... I added some more const-poison, though -- this time to the
regex_t-pointers.

> /usr/src/usr.bin/sed/compile.c:913:28: warning: cast from 'const char *' =
to
>      'unsigned char *' drops const qualifier [-Wcast-qual]

Fixed -- by adding const to casting (and p's declaration) as well.

It now compiles cleanly here with clang-3.4.1 (base), as well as clang-3.8.0
and gcc-6.0. Thanks!

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-195929-8-jXEfyLRP2M>