Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Oct 2010 18:31:56 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r213592 - stable/7/sys/pci
Message-ID:  <201010081831.o98IVuAT003071@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Fri Oct  8 18:31:56 2010
New Revision: 213592
URL: http://svn.freebsd.org/changeset/base/213592

Log:
  MFC r188392:
    Destroy TX tag outside of loop scope.
  
    Found with:	Coverity Prevent(tm)
    CID:		3886

Modified:
  stable/7/sys/pci/if_rl.c
Directory Properties:
  stable/7/sys/   (props changed)
  stable/7/sys/cddl/contrib/opensolaris/   (props changed)
  stable/7/sys/contrib/dev/acpica/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)

Modified: stable/7/sys/pci/if_rl.c
==============================================================================
--- stable/7/sys/pci/if_rl.c	Fri Oct  8 18:26:14 2010	(r213591)
+++ stable/7/sys/pci/if_rl.c	Fri Oct  8 18:31:56 2010	(r213592)
@@ -1173,9 +1173,9 @@ rl_dma_free(struct rl_softc *sc)
 				    sc->rl_cdata.rl_tx_dmamap[i]);
 				sc->rl_cdata.rl_tx_dmamap[i] = NULL;
 			}
+		}
 		bus_dma_tag_destroy(sc->rl_cdata.rl_tx_tag);
 		sc->rl_cdata.rl_tx_tag = NULL;
-		}
 	}
 
 	if (sc->rl_parent_tag != NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010081831.o98IVuAT003071>