From owner-freebsd-hackers@FreeBSD.ORG Thu Nov 13 20:30:52 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1B8796EE; Thu, 13 Nov 2014 20:30:52 +0000 (UTC) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com [IPv6:2607:f8b0:4001:c05::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D6904FB; Thu, 13 Nov 2014 20:30:51 +0000 (UTC) Received: by mail-ig0-f181.google.com with SMTP id l13so386778iga.14 for ; Thu, 13 Nov 2014 12:30:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=EYYrKEUZZxKeJpOyX7WRnVg3E+AF5z2QG2xMyV8AuHw=; b=lR9TrNwGL+gR69DoO/oPioVjg/1gE4yDi0PX4hJGr8IDIIPMeQCCp3jSWeOXBj5La/ 60XO0RktZh/Bg69j7aL+iKlREd22glEPJCirRo9VFtOQbV5e5wzoBYa7GxtxBCpGl9fx ut6bZQX0p0JgJkQQE3n6KOoKz+09Nff1Q6lokBCdrEjNmKdLh8KBZbz1+rrbmcFvUUIg 5a3PpOSCcbp7GIOHwRdAQN7N5ZEwNGSk+oHowFWDg2VTfIVHKicmqhqHf8pHgQrTxEXN b9qLn2jXyvwtDnGd2pWDLHp7A6Scch6uE56WMm2Uf6N9RXTd9vgrnI/9Ml4DXEYl0DMo E8kw== MIME-Version: 1.0 X-Received: by 10.50.66.227 with SMTP id i3mr1238079igt.25.1415910651227; Thu, 13 Nov 2014 12:30:51 -0800 (PST) Sender: jdavidlists@gmail.com Received: by 10.43.96.202 with HTTP; Thu, 13 Nov 2014 12:30:51 -0800 (PST) In-Reply-To: References: Date: Thu, 13 Nov 2014 15:30:51 -0500 X-Google-Sender-Auth: 06wtB3AUom5IvkrEtwySWyqkan0 Message-ID: Subject: Re: Checksumming outgoing packets in PF vs in ip[6]_output From: J David To: Ilya Bakulin Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-hackers@freebsd.org" , freebsd-net@freebsd.org, freebsd-pf@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 20:30:52 -0000 On Wed, Nov 5, 2014 at 9:28 AM, Ilya Bakulin wrote: > Of course it was interesting what does the upstream PF do (@ OpenBSD). Seems > they have made the decision to > leave the task of recalculating the checksums for outgoing packets to > ip[6]_output, because currently > the code there overwrites the checksum anyway. > This seems a correct way to me. pf should not longer do any checksum updates > in inbound and outbound path. Is there any chance this change would help with bug 179392 as well? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=179392 Or is that a separate issue? Thanks!