Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 May 2014 16:38:05 +0000 (UTC)
From:      "Alexander V. Chernikov" <melifaro@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r265280 - head/sys/net
Message-ID:  <201405031638.s43Gc5uT049404@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: melifaro
Date: Sat May  3 16:38:05 2014
New Revision: 265280
URL: http://svnweb.freebsd.org/changeset/base/265280

Log:
  Remove additional fib checks from rtalloc1_fib.
  It looks like current consumers are either unaware
  of MRT (and uses RT_DEFAULT_FIB implicitly) or
  know what thay are doing, In latter case they
  will be either hit by KASSERT or ESCRH will be returned
  due to NULL rnh.

Modified:
  head/sys/net/route.c

Modified: head/sys/net/route.c
==============================================================================
--- head/sys/net/route.c	Sat May  3 16:28:54 2014	(r265279)
+++ head/sys/net/route.c	Sat May  3 16:38:05 2014	(r265280)
@@ -402,15 +402,6 @@ rtalloc1_fib(struct sockaddr *dst, int r
 	int needlock;
 
 	KASSERT((fibnum < rt_numfibs), ("rtalloc1_fib: bad fibnum"));
-	switch (dst->sa_family) {
-	case AF_INET6:
-	case AF_INET:
-		/* We support multiple FIBs. */
-		break;
-	default:
-		fibnum = RT_DEFAULT_FIB;
-		break;
-	}
 	rnh = rt_tables_get_rnh(fibnum, dst->sa_family);
 	newrt = NULL;
 	if (rnh == NULL)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405031638.s43Gc5uT049404>