Date: Fri, 19 Jun 2015 16:40:16 +0200 From: Hans Petter Selasky <hps@selasky.org> To: araujo@FreeBSD.org Cc: David Chisnall <theraven@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r268137 - head/sys/sys Message-ID: <558429D0.1000808@selasky.org> In-Reply-To: <CAOfEmZi1fcU%2BeKagE2idbBahtrQYdgTyRa4afw-zr1_s5k1OwQ@mail.gmail.com> References: <201407020845.s628jRG5031824@svn.freebsd.org> <5BE3492F-86A0-4CE3-A27C-8DB5EB662C64@FreeBSD.org> <5583F2C9.1030409@selasky.org> <1EB851FC-CA78-4A7B-BE5D-4F050C61A14C@FreeBSD.org> <558403C4.4040500@selasky.org> <FE96503D-D821-4B7F-8AA5-7A80E4051CFA@FreeBSD.org> <55841BF3.8010205@selasky.org> <74BE6DD6-1C0F-4E59-8913-CFCE7DD744CB@FreeBSD.org> <55842746.5040105@selasky.org> <CAOfEmZi1fcU%2BeKagE2idbBahtrQYdgTyRa4afw-zr1_s5k1OwQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/19/15 16:32, Marcelo Araujo wrote: > 2015-06-19 22:29 GMT+08:00 Hans Petter Selasky <hps@selasky.org>: > >> On 06/19/15 16:22, David Chisnall wrote: >> >>>> Right - can you explain why it is ending up in your ObjC code? >>>> >>> Because it’s in cdefs.h, which is included by*every single userspace C >>> header*. cdefs.h must work with all C-family languages. >>> >>> David >>> >>> >> Hi David, >> >> My buildworld and buildkernel has just successfully completed. I'll rename >> the define and its clients in -current shortly. Will be MFC'ed to 10-stable >> in 1 weeks time, so that any errors out there in ports will show up. Is >> this fine by you? >> >> Instead of __weak it will be __weak_symbol . Googled a bit about >> __weak_symbol and it seems to be free. >> >> > Hi, > > Maybe would be a good idea run an 'exp run' with this patch? Just to double > check if any port will break, although after you rename, I don't believe it > will conflict anymore, however an 'exp run' would show you it. > > > Best Regards, > Hi, Here is a PR and a patch. Let's move the discussion over there if any further issues: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200972 --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?558429D0.1000808>