From owner-cvs-all@FreeBSD.ORG  Sat Apr 12 10:25:52 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3227D37B401
	for <cvs-all@FreeBSD.org>; Sat, 12 Apr 2003 10:25:52 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id B6F3543FD7
	for <cvs-all@FreeBSD.org>; Sat, 12 Apr 2003 10:25:48 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 38385 invoked by uid 1000); 12 Apr 2003 17:25:49 -0000
Date: Sat, 12 Apr 2003 10:25:49 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Poul-Henning Kamp <phk@FreeBSD.org>
In-Reply-To: <20030412084521.D835137B41D@hub.freebsd.org>
Message-ID: <Pine.BSF.4.21.0304121013010.38364-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Apr 2003 17:25:52 -0000

On Sat, 12 Apr 2003, Poul-Henning Kamp wrote:
>   Modified files:
>     sys/cam/scsi         scsi_da.c 
>   Log:
>   Remove the unused ioctl routine.
>   
>   Revision  Changes    Path
>   1.137     +0 -32     src/sys/cam/scsi/scsi_da.c
>
> -static int
> -daioctl(struct disk *dp, u_long cmd, void *addr, int flag, struct thread *td)
> -{
> -	error = cam_periph_ioctl(periph, cmd, addr, daerror);

Uh, tell me who is going to call cam_periph_ioctl()?  This is necessary
to allow camcontrol to get a passthrough device.  All the other drivers
call it.

What bothers me is that you don't pay attention to MAINTAINERS:
>CAM   gibbs,
>      ken     Pre-commit review requested. send to scsi@freebsd.org

I don't think you'd be happy if I picked a random, seemingly unused
function in geom and nuked it, apparently without understanding the
impact.  Please be considerate of others.

-Nate