From owner-freebsd-current@FreeBSD.ORG Mon Jun 22 01:51:52 2015 Return-Path: Delivered-To: freebsd-current@nevdull.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 223122E5 for ; Mon, 22 Jun 2015 01:51:52 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from hub.freebsd.org (hub.freebsd.org [8.8.178.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hub.freebsd.org", Issuer "hub.freebsd.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 04A59DCB for ; Mon, 22 Jun 2015 01:51:52 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: by hub.freebsd.org (Postfix) id EEA462E4; Mon, 22 Jun 2015 01:51:51 +0000 (UTC) Delivered-To: current@nevdull.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EDCB42E3 for ; Mon, 22 Jun 2015 01:51:51 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F30DDC6; Mon, 22 Jun 2015 01:51:50 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.14.9/8.14.9) with ESMTP id t5M1pNu7056938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 22 Jun 2015 09:51:24 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.14.9/8.14.9/Submit) id t5M1pNEq056937; Mon, 22 Jun 2015 09:51:23 +0800 (CST) (envelope-from kevlo) Date: Mon, 22 Jun 2015 09:51:23 +0800 From: Kevin Lo To: Gleb Smirnoff Cc: current@FreeBSD.org, adrian@FreeBSD.org Subject: Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes Message-ID: <20150622015123.GA56922@ns.kevlo.org> References: <20150616163436.GP73119@glebius.int.ru> <20150617082855.GT73119@glebius.int.ru> <20150618081655.GA44125@ns.kevlo.org> <20150618104030.GK73119@glebius.int.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150618104030.GK73119@glebius.int.ru> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 01:51:52 -0000 On Thu, Jun 18, 2015 at 01:40:30PM +0300, Gleb Smirnoff wrote: > > On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote: > K> > you signed up as tester of urtw(4). I have converted urtw(4) > K> > and uploaded new patch at: > K> > > K> > https://reviews.freebsd.org/D2655 > K> > > K> > Please try, report and update the project page. > K> > > K> > https://wiki.freebsd.org/projects/ifnet/net80211 > K> > > K> > Thanks a lot for your help with the project. > K> > K> After bringing interface up I'm getting: > K> http://i.imgur.com/XhOVJ68.jpg > > I've found the problem and updated the diff. Please test once more. > > Thanks for help! Without you the bug could leak into subversion. Thank you Gleb. urtw(4) works fine on amd64. # dmesg |grep urtw urtw0: on usbus4 urtw0: unknown RTL8187L type: 0x8000000 urtw0: rtl8187l rf rtl8225u hwrev none One minor problem, I got an compiler error and this diff below fixes it. --- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800 +++ D2655.diff 2015-06-22 09:47:56.121431950 +0800 @@ -10421,14 +10421,6 @@ struct urtw_vap *uvp = URTW_VAP(vap); struct ieee80211_node *ni; usb_error_t error = 0; -@@ -1905,7 +1858,6 @@ - default: - break; - } --fail: - URTW_UNLOCK(sc); - IEEE80211_LOCK(ic); - return (uvp->newstate(vap, nstate, arg)); @@ -1915,12 +1867,11 @@ urtw_watchdog(void *arg) { > > -- > Totus tuus, Glebius. Kevin