Date: Sun, 2 May 2004 13:02:54 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Michael Nottebrock <michaelnottebrock@gmx.net> Cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/x11/kdebase3 Makefile pkg-message ports/x11/kdebase3/files pkg-message Message-ID: <20040502200254.GB20371@dragon.nuxi.com> In-Reply-To: <200405021932.33696.michaelnottebrock@gmx.net> References: <200405021310.i42DAoZM055616@repoman.freebsd.org> <20040502171345.GA20168@dragon.nuxi.com> <200405021932.33696.michaelnottebrock@gmx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 02, 2004 at 07:32:29PM +0200, Michael Nottebrock wrote:
> > > Reported by: obrien
> >
> > Thank you for fixing this, but why didn't you just leave pkg-message
> > where it was? Just because it needs fixing up it doesn't have to live in
> > the non-standard files/ directory. Please consider moving that and the
> > plists back to the main kdebase3 directory.
>
> I don't think a pkg-message that really isn't one but a template that
> needs to be processed first should be visible, so I'd rather hide it in
> ${FILESDIR}. Perhaps I should have renamed it to message-template?
> Also, our plist bits aren't standard plists (the real plist is
> concatenated from them, depending on build options) and thus don't
> belong into the portdir, but into ${FILESDIR}.
I TOTALLY disagree with this hiding these standard files in ${FILESDIR}.
I've been here 10 years and haven't heard of this as a general rule to
follow. It certainly isn't documented in the Porter's Handbook.
Look at editors/vim, lang/gcc3[1234], astro/xplanet, audio/fmio,
biology/distribfold, databases/py-MySQL, devel/cvsweb, devel/perforce,
mail/cyrus-imapd, net/samba, sysutils/webmin, textproc/aspell,
extproc/ispell, www/squid, x11/xscreensaver, (total of 133 ports)
for examples of ports that tweak, modify and/or add major content to
${TMPPLIST} at build-time.
Same for pkg-message. See astro/setiathome/Makefile as a correct
example.
Obfuscating standard ports files does not benefit users and makes the
Ports Collection harder to use than it needs to be.
--
-- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040502200254.GB20371>