From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Aug 14 09:39:13 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7F54B54F for ; Thu, 14 Aug 2014 09:39:13 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 66ED02B96 for ; Thu, 14 Aug 2014 09:39:13 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7E9dDQr050825 for ; Thu, 14 Aug 2014 09:39:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192642] update mail/mailagent to a non-interactive, regular port Date: Thu, 14 Aug 2014 09:39:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: marino@FreeBSD.org X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2014 09:39:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192642 --- Comment #15 from John Marino --- (In reply to Yoshiaki Kasahara from comment #14) > I decided to move examples files in post-install. I hope using ${MV} > here is acceptable. Update pkg-plist accordingly. Also delete symlink > related lines from Makefile and pkg-plist. that's all fine. > Use pkg-deinstall to remove $orgname file instead of pkg-plist. I'm wondering if that's a good idea. There's a big push to reduce the number of files in ports, which is why you often see pkg-plist embedded in Makefile to save a single inode (which costs 4kb). If pkg-plist can handle a conditional delete and it saves a file, we should probably leave that how it was. > Define the filename for $orgname as a variable and use SUB_FILES to > generate pkg-{install,deinstall,message} (to make it easier to change). sounds good. > I checked the update port using poudriere testport with 9.3R and 10.0R. > If you need the entire output of that, I'll upload them later. no, I trust you. We always run the tests ourselves, but I like to have a good probably that it will pass the first time. > P.S. Poudriere is a great tool. I love it. :) I've made a few converts to poudriere due to my "demands" during triage. -- You are receiving this mail because: You are the assignee for the bug.