From owner-svn-ports-all@FreeBSD.ORG Thu Mar 28 02:58:11 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7F88D762 for ; Thu, 28 Mar 2013 02:58:11 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by mx1.freebsd.org (Postfix) with ESMTP id 595D9229 for ; Thu, 28 Mar 2013 02:58:11 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id x11so939487pdj.10 for ; Wed, 27 Mar 2013 19:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=MlfmiLfORIR2IOIuPbSWQUoYiLwC6xNBmEfMjg6d7T0=; b=XltKXdwnARVTBeATSCeUgs3xanOP8B9iFdEGZ+AfjPJlHfFiVZU+Csxnnym+1NOzn5 IafDIrTkaWrsguhNPacPAU7/i0IPFT3bf6X4Pkfg/IOwHKgIF84CgRtON1tIBUt8hqas ZOQj+L0HlOjPQa3S79kj2BwSAwiTcHKaIeZfQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=MlfmiLfORIR2IOIuPbSWQUoYiLwC6xNBmEfMjg6d7T0=; b=AkoeZYKAX+Z5tNCkPi2nEZN93pM4dvz+uSQYe+vNFf77BXlz1tLvun672i7H83FIET w8Dq12GdRJ/FXhy7LKLQ/sYOixeJR4bGNynkTnMS6SLeeIvmZZ1td9tIUeoWQES8ugtk vQeu0ppRe8an5PaO0xZMdUv5z2PRpHIiFytvJYq4ktY94saVsbW4OpF9NuK5y/9MH3fR vkYisWnCU6amYer27DabxoqADamAinilaa4UIgddmsC3Vm0CKQ2r35AazfC6LUErfXe2 6Fk76LCxrOun0ZojiUd3joWYmBkWIuJLmGu+zwwhHnZR6anMzGuP6RccJPklI8uDQWXo tIBA== X-Received: by 10.68.180.227 with SMTP id dr3mr17831529pbc.56.1364439485022; Wed, 27 Mar 2013 19:58:05 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.246.3 with HTTP; Wed, 27 Mar 2013 19:57:34 -0700 (PDT) In-Reply-To: <20130328025321.GC72629@FreeBSD.org> References: <201303251359.r2PDxIXf035701@svn.freebsd.org> <20130328025321.GC72629@FreeBSD.org> From: Eitan Adler Date: Wed, 27 Mar 2013 22:57:34 -0400 X-Google-Sender-Auth: rYEsZ81pZrKkmyxvFoxL9_EyCXY Message-ID: Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnBOp+v3xs+jq4MnUhHnaIY2yM1qnc0H38t/0HNjzRBBjKBg9dgAE66qCsKUgMDC5DmaZSh Cc: svn-ports-head@freebsd.org, Max Brazhnikov , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2013 02:58:11 -0000 On 27 March 2013 22:53, Alexey Dokuchaev wrote: > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote: >> New Revision: 315222 >> URL: http://svnweb.freebsd.org/changeset/ports/315222 >> >> - Remove OPTIONS_DEFINE, if it contains only global options > > Can you elaborate on this one? Given that there is no clear policy, > personally I've been always including OPTIONS_DEFINE, even if just for, say, > DOCS. Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set globally (e.g., OPTIONS_UNSET= NLS) and not per port. As such, it can reduce user annoyance if the dialog box is not shown for such options. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams