Date: Fri, 06 Oct 2017 00:57:57 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 222807] PURE entropy sources are harvested but not mixed in. Also, min-entropy low per SP800-90B measurements Message-ID: <bug-222807-8-BMZW1srseQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-222807-8@https.bugs.freebsd.org/bugzilla/> References: <bug-222807-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222807 --- Comment #2 from Conrad Meyer <cem@freebsd.org> --- (In reply to W. Dean Freeman from comment #1) For this 2nd patch, I don't see any value in making it optional. Does that seem reasonable to you or can you make a case for the HBSD_RANDOM_HIGH_ENTR= OPY option? Also re: 2nd patch, this code seems totally broken: + fortuna_state.fs_pool[pl].fsp_length =3D MIN(RANDOM_FORTUNA_MAXPOOL= SIZE, + fortuna_state.fs_pool[pl].fsp_length + sizeof(event->he_somecounter) + + event->he_size); Note that fsp_length is of type u_int and RANDOM_FORTUNA_MAXPOOLSIZE is UINT_MAX. You aren't doing saturating arithmetic, but instead just overflowing. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-222807-8-BMZW1srseQ>