Date: Sat, 12 Jan 2013 09:00:13 +0100 From: Florian Smeets <flo@smeets.im> To: Emanuel Haupt <ehaupt@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r310227 - head/www/firefox Message-ID: <50F1180D.1050405@smeets.im> In-Reply-To: <201301111022.r0BAMeQ1061732@svn.freebsd.org> References: <201301111022.r0BAMeQ1061732@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OLQKFJJVVLTJBXSXUOVE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11.01.13 11:22, Emanuel Haupt wrote: > Author: ehaupt > Date: Fri Jan 11 10:22:40 2013 > New Revision: 310227 > URL: http://svnweb.freebsd.org/changeset/ports/310227 >=20 > Log: > Remove CRLF in order for a patch to apply. > =20 > Approved by: gahr (gecko) >=20 Looks like we have a new team member :) As some people were implying I didn't test this update, here is an explanation. (It took me 3 days to test this update properly BTW. That is also the reason why I updated to 17.0.2 first as I was not confident with the status of 18.0 at that time.) That said gecko@ needs testers! We have almost all betas of thunderbird, firefox and seamonkey in our svn repo weeks before the release, together with all the infrastructure changes required for those versions. On release day we usually only bump the version and update the distinfo. Repo address: https://trillian.chruetertee.ch/svn/freebsd-gecko/trunk/ Now the explanation what happened: This file was giving me a hard time when trying to add/commit it. It complained about "inconsistent svn:eol-style". So I tried to set the correct eol-style instead of "native", but that didn't work out. So I discussed this with Beat and we decided to delete the svn property. That seems to have worked for the same file in seamonkey but not for the on in firefox. (I likely did it wrong for firefox...) So for firefox the property was still "native", on checkout the file would be in UNIX LF format and would fail to apply. But locally on my box it still had DOS LF and applied fine. And for the queue.h patch failure it was more or less the same, what I checked into svn would checkout differently due to $FreeBSD$ expansion. This is not looking for excuses, it's just a bit frustrating when you spend a lot of time trying to make this work, and people shout at you for not testing. Anyway, Emanuel thank you for taking care of it! Much appreciated. Thanks, Florian ------enig2OLQKFJJVVLTJBXSXUOVE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlDxGA0ACgkQapo8P8lCvwnNfQCgsk0c6f43M8js71RVOP32S8FI SDEAn2t/ZswGOxlwn2kJm+cMD0srU3K4 =sYXZ -----END PGP SIGNATURE----- ------enig2OLQKFJJVVLTJBXSXUOVE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50F1180D.1050405>