From owner-freebsd-ports@FreeBSD.ORG Tue Mar 18 20:07:22 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3588106566C for ; Tue, 18 Mar 2008 20:07:22 +0000 (UTC) (envelope-from bsam@ipt.ru) Received: from services.ipt.ru (services.ipt.ru [194.62.233.110]) by mx1.freebsd.org (Postfix) with ESMTP id B4E0D8FC14 for ; Tue, 18 Mar 2008 20:07:22 +0000 (UTC) (envelope-from bsam@ipt.ru) Received: from [85.173.16.182] (helo=localhost.my.domain) by services.ipt.ru with esmtpa (Exim 4.54 (FreeBSD)) id 1Jbi5g-000B0G-Jz; Tue, 18 Mar 2008 23:07:20 +0300 To: "Anatoly Borodin" References: From: Boris Samorodov Date: Tue, 18 Mar 2008 23:06:57 +0300 In-Reply-To: (Anatoly Borodin's message of "Tue\, 18 Mar 2008 18\:09\:36 +0200") Message-ID: <53437470@ipt.ru> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander@Leidinger.net, freebsd-ports@freebsd.org Subject: Re: PLIST=pkg-plist X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Mar 2008 20:07:23 -0000 On Tue, 18 Mar 2008 18:09:36 +0200 Anatoly Borodin wrote: > > grep -r 'PLIST[[:space:]]*=[[:space:]]*pkg-plist' --include "Makefile*" /usr/ports > /usr/ports/audio/linux-esound/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/audio/linux-libaudiofile/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/devel/linux-libglade/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/devel/linux-libglade2/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/emulators/linux_base-f7/Makefile:PLIST= > pkg-plist > /usr/ports/emulators/linux_base-fc4/Makefile:PLIST= > pkg-plist > /usr/ports/emulators/linux_base-fc6/Makefile:PLIST= > pkg-plist > /usr/ports/games/qix/Makefile:PLIST= pkg-plist.x11 > /usr/ports/graphics/linux-imlib/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/graphics/linux-tiff/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/graphics/linux-ungif/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/security/ossec-hids-client/Makefile:PLIST= pkg-plist.client > /usr/ports/textproc/linux-libxml/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/textproc/linux-libxml2/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/x11-toolkits/linux-gtk/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > /usr/ports/x11-toolkits/linux-qt33/Makefile:PLIST= > pkg-plist.${LINUX_RPM_ARCH} > It works without /usr/obj while the 'work' dir is in the port's dir, > but doesn't work with /usr/obj (e.g. > /var/db/pkg/linux_base-fc-4_10/+CONTENTS contains only conflicts and > no file references. > IMHO it should be changed to 'PLIST=${WRKDIR}/pkg-list.*' or > 'PLIST=${PKGDIR}/pkg-plist.*' or removed at all (depending on the > semantics). > Does it look reasonable? Yes, 'PLIST=${PKGDIR}/pkg-plist.*' is good imo. Can you submit a PR? Alexander (CCed), what do you think? WBR -- bsam