From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jun 27 07:40:11 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 145D237B401 for ; Fri, 27 Jun 2003 07:40:11 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BC9143FAF for ; Fri, 27 Jun 2003 07:40:10 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h5REeAUp092475 for ; Fri, 27 Jun 2003 07:40:10 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h5REeAkm092474; Fri, 27 Jun 2003 07:40:10 -0700 (PDT) Date: Fri, 27 Jun 2003 07:40:10 -0700 (PDT) Message-Id: <200306271440.h5REeAkm092474@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Christian Weisgerber Subject: Re: ports/53818: New port: textproc/xmlcatmgr X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Christian Weisgerber List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jun 2003 14:40:11 -0000 The following reply was made to PR ports/53818; it has been noted by GNATS. From: Christian Weisgerber To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: Re: ports/53818: New port: textproc/xmlcatmgr Date: Fri, 27 Jun 2003 16:25:49 +0200 (CEST) > Xpost-install: > X @if [ -r ${CATALOG_MASTER_SGML} ]; then\ > X ${WRKSRC}/bin/xmlcatmgr -sc ${CATALOG_MASTER_SGML} add CATALOG > catalog.ports;\ [...] So this is only executed when the port is installed, but not when the corresponding package is installed. I think this behavior is wrong. The commands should be moved into a pkg-install script, which will be executed automatically when the package is installed. For port installs, you can add a post-install target that simply calls pkg-install. I would also like to suggest some phrasing improvements: diff -ur xmlcatmgr.orig/Makefile xmlcatmgr/Makefile --- xmlcatmgr.orig/Makefile Fri Jun 27 16:20:38 2003 +++ xmlcatmgr/Makefile Fri Jun 27 16:17:30 2003 @@ -62,7 +62,7 @@ ${INSTALL_DATA} ${WRKDIR}/catalog.xml ${CATALOG_MASTER_XML};\ fi @if [ -r ${CATALOG_PORTS_XML} ]; then\ - echo "Skipped: ${CATALOG_PORTS_XML} is already exist.";\ + echo "Skipped: ${CATALOG_PORTS_XML} already exists.";\ else\ ${INSTALL_DATA} ${WRKDIR}/catalog.ports.xml ${CATALOG_PORTS_XML};\ fi diff -ur xmlcatmgr.orig/pkg-message xmlcatmgr/pkg-message --- xmlcatmgr.orig/pkg-message Fri Jun 27 16:20:38 2003 +++ xmlcatmgr/pkg-message Fri Jun 27 16:19:39 2003 @@ -3,20 +3,20 @@ 1) ${PREFIX}/share/sgml/catalog The top level catalog for SGML stuff. This is not changed - by ports/packages but textproc/xmlcatmgr. + by any ports or packages except textproc/xmlcatmgr. 2) ${PREFIX}/share/sgml/catalog.ports - The catalog is for handling SGML stuff installed under - ${PREFIX}/share/sgml. This is changed by ports/packages. + This catalog is for handling SGML stuff installed under + ${PREFIX}/share/sgml. It is changed by ports and packages. 3) ${PREFIX}/share/xml/catalog The top level catalog for XML stuff. This is not changed - by ports/packages but textproc/xmlcatmgr. + by any ports or packages except textproc/xmlcatmgr. 4) ${PREFIX}/share/xml/catalog.ports - The catalog is for handling XML stuff installed under - ${PREFIX}/share/xml. This is changed by ports/packages. + This catalog is for handling XML stuff installed under + ${PREFIX}/share/xml. It is changed by ports and packages. -- Christian "naddy" Weisgerber naddy@mips.inka.de