Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 08 Dec 2012 23:27:59 +0100
From:      Guido Falsi <madpilot@FreeBSD.org>
To:        Eitan Adler <lists@eitanadler.com>
Cc:        freebsd-doc@freebsd.org, bapt@freebsd.org
Subject:   Re: Patch for porter's handbook
Message-ID:  <50C3BEEF.5070809@FreeBSD.org>
In-Reply-To: <CAF6rxg=V9RHeeY=e39xaJDzKFw6a_k%2BbqVR7k%2B942O5q1PfhYw@mail.gmail.com>
References:  <50C3AEE6.3020101@FreeBSD.org> <CAF6rxgkDTMgsNuu8%2BtpahmAXeHHVftxPQ6AeSR2pcrr3_YNawg@mail.gmail.com> <50C3B788.6050809@FreeBSD.org> <CAF6rxg=V9RHeeY=e39xaJDzKFw6a_k%2BbqVR7k%2B942O5q1PfhYw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------030409050502040805080505
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/08/12 23:04, Eitan Adler wrote:
> On 8 December 2012 16:56, Guido Falsi <madpilot@freebsd.org> wrote:
>> On 12/08/12 22:22, Eitan Adler wrote:
>>>
>>> On 8 December 2012 16:19, Guido Falsi <madpilot@freebsd.org> wrote:
>>>>
>>>> Hi!
>>>> Some time ago the maintainer of net-mgmt/mrtg noticed that the porter's
>>>> handbook still reference NOPORTDOCS in place of the new DOCS option in
>>>> optionsng.
>>>>
>>>> I have a patch(attached) which fixes this. bapt has already seen it and
>>>> approved it, as suggested by him I added a tag around "DOCS".
>>>>
>>>> I'd like this patch to be revised by someone of the documentation team
>>>> and
>>>> approved for committing it. I'm obviously accepting any comment or
>>>> correction.
>>>
>>>
>>> The content changes look good. However, please don't make whitespace /
>>> formatting changes in the same patch as this makes it harder to figure
>>> out what changed for both the reviewers and translators.
>>>
>>
>> Good point. Here is a revised patch with only the content changes included.
>
> Looks good to me.
>
> Not your text but:
>
> "and neither would be added to port packing list" doesn't sound quite
> right.  Try replacing "and neither would be" with "or".
>

Done. final patch for approval attached.


-- 
Guido Falsi <madpilot@FreeBSD.org>

--------------030409050502040805080505
Content-Type: text/plain; charset=us-ascii;
 name="porthand.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="porthand.diff"

SW5kZXg6IGVuX1VTLklTTzg4NTktMS9ib29rcy9wb3J0ZXJzLWhhbmRib29rL2Jvb2sueG1s
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIGVuX1VTLklTTzg4NTktMS9ib29rcy9wb3J0ZXJzLWhhbmRi
b29rL2Jvb2sueG1sCShyZXZpc2lvbiA0MDMwNykKKysrIGVuX1VTLklTTzg4NTktMS9ib29r
cy9wb3J0ZXJzLWhhbmRib29rL2Jvb2sueG1sCSh3b3JraW5nIGNvcHkpCkBAIC00OTIyLDEx
ICs0OTIyLDExIEBACiAJICA8bWFrZXZhcj5QS0dOQU1FPC9tYWtldmFyPi48L3BhcmE+CiAK
IAk8cGFyYT5NYWtlIHRoZSBpbnN0YWxsYXRpb24gZGVwZW5kZW50IG9uIHRoZSB2YXJpYWJs
ZQotCSAgPG1ha2V2YXI+Tk9QT1JURE9DUzwvbWFrZXZhcj4gc28gdGhhdCB1c2VycyBjYW4g
ZGlzYWJsZSBpdAorCSAgPGxpdGVyYWw+RE9DUzwvbGl0ZXJhbD4gb3B0aW9uIHNvIHRoYXQg
dXNlcnMgY2FuIGRpc2FibGUgaXQKIAkgIGluIDxmaWxlbmFtZT4vZXRjL21ha2UuY29uZjwv
ZmlsZW5hbWU+LCBsaWtlIHRoaXM6PC9wYXJhPgogCiAJPHByb2dyYW1saXN0aW5nPnBvc3Qt
aW5zdGFsbDoKLS5pZiAhZGVmaW5lZChOT1BPUlRET0NTKQorLmlmICR7UE9SVF9PUFRJT05T
Ok1ET0NTfQogCSR7TUtESVJ9ICR7RE9DU0RJUn0KIAkke0lOU1RBTExfTUFOfSAke1dSS1NS
Q30vZG9jcy94dmRvY3MucHMgJHtET0NTRElSfQogLmVuZGlmPC9wcm9ncmFtbGlzdGluZz4K
QEAgLTQ5NjgsMTMgKzQ5NjgsMTMgQEAKIAk8L2l0ZW1pemVkbGlzdD4KIAogCTxub3RlPgot
CSAgPHBhcmE+PG1ha2V2YXI+Tk9QT1JURE9DUzwvbWFrZXZhcj4gb25seSBjb250cm9scyBh
ZGRpdGlvbmFsCisJICA8cGFyYT5UaGUgPGxpdGVyYWw+RE9DUzwvbGl0ZXJhbD4gb3B0aW9u
IG9ubHkgY29udHJvbHMgYWRkaXRpb25hbAogCSAgICBkb2N1bWVudGF0aW9uIGluc3RhbGxl
ZCBpbiA8bWFrZXZhcj5ET0NTRElSPC9tYWtldmFyPi4gIEl0CiAJICAgIGRvZXMgbm90IGFw
cGx5IHRvIHN0YW5kYXJkIG1hbiBwYWdlcyBhbmQgaW5mbyBwYWdlcy4KIAkgICAgVGhpbmdz
IGluc3RhbGxlZCBpbiA8bWFrZXZhcj5EQVRBRElSPC9tYWtldmFyPiBhbmQKIAkgICAgPG1h
a2V2YXI+RVhBTVBMRVNESVI8L21ha2V2YXI+IGFyZSBjb250cm9sbGVkIGJ5Ci0JICAgIDxt
YWtldmFyPk5PUE9SVERBVEE8L21ha2V2YXI+IGFuZAotCSAgICA8bWFrZXZhcj5OT1BPUlRF
WEFNUExFUzwvbWFrZXZhcj4sIHJlc3BlY3RpdmVseS48L3BhcmE+CisJICAgIDxsaXRlcmFs
PkRBVEE8L2xpdGVyYWw+IGFuZAorCSAgICA8bGl0ZXJhbD5FWEFNUExFUzwvbGl0ZXJhbD4g
b3B0aW9ucywgcmVzcGVjdGl2ZWx5LjwvcGFyYT4KIAk8L25vdGU+CiAKIAk8cGFyYT5UaGVz
ZSB2YXJpYWJsZXMgYXJlIGV4cG9ydGVkIHRvCkBAIC01MDA4LDEwICs1MDA4LDEwIEBACiAJ
ICBpcyBsaXN0ZWQgaW4gPG1ha2V2YXI+UE9SVERPQ1M8L21ha2V2YXI+IG9yIG1hdGNoZWQg
YnkgYQogCSAgZ2xvYiBwYXR0ZXJuIGZyb20gdGhpcyB2YXJpYWJsZSwgdGhlIGVudGlyZSBz
dWJ0cmVlIG9mCiAJICBjb250YWluZWQgZmlsZXMgYW5kIGRpcmVjdG9yaWVzIHdpbGwgYmUg
cmVnaXN0ZXJlZCBpbiB0aGUKLQkgIGZpbmFsIHBhY2tpbmcgbGlzdC4gIElmIDxtYWtldmFy
Pk5PUE9SVERPQ1M8L21ha2V2YXI+IGlzCi0JICBkZWZpbmVkIHRoZW4gZmlsZXMgYW5kIGRp
cmVjdG9yaWVzIGxpc3RlZCBpbgotCSAgPG1ha2V2YXI+UE9SVERPQ1M8L21ha2V2YXI+IHdv
dWxkIG5vdCBiZSBpbnN0YWxsZWQgYW5kCi0JICBuZWl0aGVyIHdvdWxkIGJlIGFkZGVkIHRv
IHBvcnQgcGFja2luZyBsaXN0LiAgSW5zdGFsbGluZyB0aGUKKwkgIGZpbmFsIHBhY2tpbmcg
bGlzdC4gIElmIHRoZSA8bGl0ZXJhbD5ET0NTPC9saXRlcmFsPiBvcHRpb24gaGFzCisJICBi
ZWVuIHVuc2V0IHRoZW4gZmlsZXMgYW5kIGRpcmVjdG9yaWVzIGxpc3RlZCBpbgorCSAgPG1h
a2V2YXI+UE9SVERPQ1M8L21ha2V2YXI+IHdvdWxkIG5vdCBiZSBpbnN0YWxsZWQKKwkgIG9y
IGFkZGVkIHRvIHBvcnQgcGFja2luZyBsaXN0LiAgSW5zdGFsbGluZyB0aGUKIAkgIGRvY3Vt
ZW50YXRpb24gYXQgPG1ha2V2YXI+UE9SVERPQ1M8L21ha2V2YXI+IGFzIHNob3duIGFib3Zl
CiAJICByZW1haW5zIHVwIHRvIHRoZSBwb3J0IGl0c2VsZi4gIEEgdHlwaWNhbCBleGFtcGxl
IG9mCiAJICB1dGlsaXppbmcgPG1ha2V2YXI+UE9SVERPQ1M8L21ha2V2YXI+IGxvb2tzIGFz
Cg==
--------------030409050502040805080505--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50C3BEEF.5070809>