From owner-freebsd-current@FreeBSD.ORG  Tue Jul 23 13:34:19 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 5BB5B1A6;
 Tue, 23 Jul 2013 13:34:19 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3884C2EA7;
 Tue, 23 Jul 2013 13:34:18 +0000 (UTC)
Received: from Julian-MBP3.local (etroy.elischer.org [121.45.226.51])
 (authenticated bits=0)
 by vps1.elischer.org (8.14.6/8.14.6) with ESMTP id r6NDY51O004312
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Tue, 23 Jul 2013 06:34:08 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Message-ID: <51EE8647.3080401@freebsd.org>
Date: Tue, 23 Jul 2013 21:33:59 +0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: "Andrey V. Elsukov" <ae@FreeBSD.org>
Subject: Re: IPSEC crashes after r253088
References: <20130721054323.915f865769e6042c7dc62d08@tackymt.homeip.net>
 <51EE309D.2030106@FreeBSD.org> <51EE68D8.9020603@freebsd.org>
 <51EE7066.9030403@FreeBSD.org>
In-Reply-To: <51EE7066.9030403@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: George Neville-Neil <gnn@FreeBSD.org>,
 Taku YAMAMOTO <taku@tackymt.homeip.net>, freebsd-current@freebsd.org,
 Andre Oppermann <andre@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2013 13:34:19 -0000

On 7/23/13 8:00 PM, Andrey V. Elsukov wrote:
> On 23.07.2013 15:28, Andre Oppermann wrote:
>> On 23.07.2013 09:28, Andrey V. Elsukov wrote:
>>> On 21.07.2013 00:43, Taku YAMAMOTO wrote:
>>>> After r253088, systems with IPSEC and KSTACK_PAGES < 4 crashes on
>>>> booting into multi-user mode.
>>>>
>>>> The crash is due to sysctl -a in /etc/rc.d/initrandom ended up with
>>>> kernel stack overflow.
>>>> where type is struct ipsecstat which is 12560 bytes of size (larger than
>>>> 3 pages) of size when processing net.inet.ipsec.ipsecstats.
>>> Hi,
>>>
>>> Only few fields of struct ipsecstat is used, the rest fields are never
>>> updated. We can split it to several structures, or just remove unused
>>> fields. What is better?
>> Not storing it on the stack?
> Also, I already prepared patch to test.

'both'.. one isn't supposed to have structures of any size on the 
stack in the kernel.
At one stage the max was 64 bytes.. has grown since then obviously.
*And* it could do with simplification.

>
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"